openstack/neutron
Code Issues Proposed changes

objects: use correct object class name in NeutronPrimaryKeyMissing

Browse Source 
We were passing cls.__class__ as the object type into the exception
error message. But in case of DeclarativeObject based classes (all
NeutronDbObject classes), the result of it is a message like:

neutron.objects.base.NeutronPrimaryKeyMissing: For class
DeclarativeObject missing primary keys: set([])

Note the class name is DeclarativeObject, not the intented object class
name.

Change-Id: I005512b4edf6e4c68a803f4180983e4a01e4f036
This commit is contained in:
Ihar Hrachyshka 2016-08-27 07:32:46 +00:00
parent 5a30c0f858
commit e39a61b605
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/objects/base.py
View File

@ -387,7 +387,7 @@ class NeutronDbObject(NeutronObject):
all_keys = itertools.chain([cls.primary_keys], cls.unique_keys)
if not any(lookup_keys.issuperset(keys) for keys in all_keys):
missing_keys = set(cls.primary_keys).difference(lookup_keys)
raise NeutronPrimaryKeyMissing(object_class=cls.__class__,
raise NeutronPrimaryKeyMissing(object_class=cls.__name__,
missing_keys=missing_keys)
with db_api.autonested_transaction(context.session):