In comments given automatically by abandon_old_reviews.sh script
there was still Jenkins mentioned as CI tool.
We are using Zuul for very long time and "zuul" user is voting
now instead of "jenkins" so this patch updates those commit
messages to make this messages correct.
TrivialFix
Change-Id: Iad119108ea82b47ac2a66b9f6f8a8bb56b57e7b6
Before this patch script was looking for patches which have
-1 vote from "jenkins". This was given in the past by zuul v2.
Now we have zuul v3 and there is "verified" vote give by "zuul"
instead so script needs to be updated also.
Change-Id: Ieba7a6d1babee99b14af45836c788741d23bc560
This script can now check and abandon old patches only from
specified project.
Project must be one of Neutron deliverables.
Project can be passed to script with parameter:
"--project <project_name>"
If no project is specified it will get old patches from all projects
which are part of neutron stadium.
Change-Id: I83b9a556d551db9f78b3d628df8648309e1dda1d
Yaml.load() return Python object may be dangerous if you receive
a YAML document from an untrusted source such as the Internet.
The function yaml.safe_load() limits this ability to simple Python
objects like integers or lists.
Reference:
https://security.openstack.org/guidelines/dg_avoid-dangerous-input-parsing-libraries.html
Change-Id: I026355f3e71b7fd3aeee2fe5c7920a1c6306ab02
Bashate is a style checker program for bash scripts. This addition
improves the quality of the current bash scripts and ensures that
any future change will follow the same standards.
Change-Id: Ia346f77632d4ac7beb288fa3aacea221d7969c87
For housekeeping reasons we have abandon_old_reviews.sh that is
used to purge blocked reviews from Gerrit. The project query
should be extended to all stadium projects. To avoid hard coding,
fetch the list from governance.o.o, parse it and feed it to
the rest of the script.
Change-Id: Iad40d78b7a72a4435382406373bb9f15c0ffc4a7
Usually I edit the script every time, to see what it would do
before the actual run. Add that mode via a flag.
Change-Id: I3ea50b905217947a43e4437b4925bb79c45a3d18
Arbitrarily restricting ourselves from using bash because developers on
platforms like netbsd don't want to install bash from ports doesn't
make sense. Any non-trivial shell script is likely to use features
like arrays or string manipulation that are poorly supported (if at
all) by sh, and the continued bumping of the number of expected bash
scripts is an indication that the check is not serving its purpose
anyway.
Along with removing the check, all shebang references to /bin/bash
have been replaced with /usr/bin/env bash in an attempt to be more
compatible across different hosts.
Change-Id: Ief72dc380cc88af38959c330897e2c127e33c332
Closes-Bug: #1440824
This adds the abandon_old_reviews.sh from the nova repository into
Neutron. This is handy for cleaning up the neutron review queues
by abandoning stale reviews stuck in the queue with a helpful
message.
Change-Id: I8920123217cb134c792dee35a5b06abde31be1d4