a640318bda
Some cleanups for commit 4fdda65a5b.
- Don't assume the path of mktemp command. It's /usr/bin/mktemp
for some platforms. eg. NetBSD. Also, always provide a template
as it's necessary for some platforms, eg. OS X. This snippet was
taken from the example in NetBSD's mktemp(1).
- Move a comment to the appropriate place.
- Improve a regex to ignore more comments.
- As the pattern for find -path is not a regex, no escape is necessary
for period.
Closes-Bug: #1405584
Change-Id: Ia8358f0f7ebe9bc445ce5aa3c4f340546f37db05
74 lines
2.4 KiB
Bash
74 lines
2.4 KiB
Bash
#! /bin/sh
|
|
|
|
# Copyright (C) 2014 VA Linux Systems Japan K.K.
|
|
# Copyright (C) 2014 YAMAMOTO Takashi <yamamoto at valinux co jp>
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
TMPDIR=`mktemp -d /tmp/${0##*/}.XXXXXX` || exit 1
|
|
export TMPDIR
|
|
trap "rm -rf $TMPDIR" EXIT
|
|
|
|
FAILURES=$TMPDIR/failures
|
|
|
|
|
|
check_opinionated_shell () {
|
|
# The purpose of this function is to avoid casual introduction of more
|
|
# bash dependency. Please consider alternatives before commiting code
|
|
# which uses bash specific features.
|
|
|
|
# Check that shell scripts are not bash opinionated (ignore comments though)
|
|
# If you cannot avoid the use of bash, please change the EXPECTED var below.
|
|
OBSERVED=$(grep -E '^([[:space:]]*[^#[:space:]]|#!).*bash' \
|
|
tox.ini tools/* | wc -l)
|
|
EXPECTED=3
|
|
if [ ${EXPECTED} -ne ${OBSERVED} ]; then
|
|
echo "Bash usage has been detected!" >>$FAILURES
|
|
fi
|
|
}
|
|
|
|
|
|
check_no_symlinks_allowed () {
|
|
# Symlinks break the package build process, so ensure that they
|
|
# do not slip in, except hidden symlinks.
|
|
if [ $(find . -type l ! -path '*/.*' | wc -l) -ge 1 ]; then
|
|
echo "Symlinks are not allowed!" >>$FAILURES
|
|
fi
|
|
}
|
|
|
|
|
|
check_pot_files_errors () {
|
|
# The job neutron-propose-translation-update does not update from
|
|
# transifex since our po files contain duplicate entries where
|
|
# obsolete entries duplicate normal entries. Prevent obsolete
|
|
# entries to slip in
|
|
find neutron -type f -regex '.*\.pot?' \
|
|
-print0|xargs -0 -n 1 msgfmt --check-format \
|
|
-o /dev/null
|
|
if [ "$?" -ne 0 ]; then
|
|
echo "PO files syntax is not correct!" >>$FAILURES
|
|
fi
|
|
}
|
|
|
|
# Add your checks here...
|
|
check_opinionated_shell
|
|
check_no_symlinks_allowed
|
|
check_pot_files_errors
|
|
|
|
# Fail, if there are emitted failures
|
|
if [ -f $FAILURES ]; then
|
|
cat $FAILURES
|
|
exit 1
|
|
fi
|