neutron/add-sort-keys-check-for-get-sorts-b9e3e86ddcb3bc3a.yaml at dc4a57d96661fcb56ff916cafbbbdc683653e9c4 - neutron - OpenDev: Free Software Needs Free Tools

openstack/neutron

pandatt 335ac4e2d9 Fix bug: AttributeError arises while sorting with standard attributes

Common neutron resource(e.g, Port) consists of:
1. Resource Attributes, e.g: Port.mac_address, etc.
2. Standard Attributes, e.g: created_at, and are shared among all
   neutron resources.
The `sort` opt only supports limited attributes. We need to filter
attributes that are defined with `is_sort_key=True` and it's preferred
to explicitly warn CLI & API users of illegal sort keys rather than
just accept without check, pass forward and then hit a internal error
which's quite confusing.

Depends-on: https://review.opendev.org/#/c/660097/
Change-Id: I8d206f909b09f1279dfcdc25c39989a67bff93d5
Closes-Bug: #1659175

2019-05-29 17:58:51 +08:00

7 lines

192 B

YAML

Raw Blame History

 ---
 fixes:
   - |
     Add sort-keys validation logic to method ``get_sorts`` in
     ``neutron.api.api_common``. See the link below for more:
     https://bugs.launchpad.net/neutron/+bug/1659175