openstack/openstack-ansible-openstack_hosts
Code Issues Proposed changes

Store openstack_host_sysstat_enabled as lower case value for sysstat.default.j2

Browse Source 
Sysstat won't enable unless the ENABLED switch has been set to true.
Passing openstack_host_sysstat_enabled as true inside jinja will end
up as a "True" value inside the /etc/default/sysstat rather then the
expected "true" value and sysstat won't start.
The added jinja filter lower will make sure that the boolean is always
stored in lower case.
Additionally openstack_host_systat_enabled was renamed to
openstack_host_sysstat_enabled to better reflect the dependency to sysstat

Change-Id: I6361433f990f96ca37dac7055062c17c2940bf70
Closes-Bug: #1530979
This commit is contained in:
Bjoern Teipel 2016-01-04 15:02:41 -06:00
parent cd1a8c0245
commit ee8f634517
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
defaults/main.yml
View File

@ -16,9 +16,9 @@
openstack_code_name: Mitaka
openstack_release: master
openstack_host_systat_enabled: true
openstack_host_systat_interval: 1
openstack_host_systat_statistics_hour: 23
openstack_host_sysstat_enabled: true
openstack_host_sysstat_interval: 1
openstack_host_sysstat_statistics_hour: 23
## Defined required kernel. presently 3.13.0-32-generic
openstack_host_required_kernel: 3.13.0-34-generic

4
templates/sysstat.cron.j2
View File

@ -4,7 +4,7 @@
PATH=/usr/lib/sysstat:/usr/sbin:/usr/sbin:/usr/bin:/sbin:/bin
# Activity reports every 10 minutes everyday
*/{{ openstack_host_systat_interval }} * * * * root command -v debian-sa1 > /dev/null && debian-sa1 1 1
*/{{ openstack_host_sysstat_interval }} * * * * root command -v debian-sa1 > /dev/null && debian-sa1 1 1
# Additional run at 23:59 to rotate the statistics file
59 {{ openstack_host_systat_statistics_hour }} * * * root command -v debian-sa1 > /dev/null && debian-sa1 60 2
59 {{ openstack_host_sysstat_statistics_hour }} * * * root command -v debian-sa1 > /dev/null && debian-sa1 60 2

2
templates/sysstat.default.j2
View File

@ -8,4 +8,4 @@
# Should sadc collect system activity informations? Valid values
# are "true" and "false". Please do not put other values, they
# will be overwritten by debconf!
ENABLED="{{ openstack_host_systat_enabled }}"
ENABLED="{{ openstack_host_sysstat_enabled | bool | lower }}"