Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: I5d38c3eb0f7fdf98d9114e692cad9ad36127ac44

defaults/main.yml

@@ -13,9 +13,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# Set the package install state for distribution packages
+# Set the package install state for distribution and pip packages
 # Options are 'present' and 'latest'
 cinder_package_state: "latest"
+cinder_pip_package_state: "latest"
 
 cinder_git_repo: https://git.openstack.org/openstack/cinder
 cinder_git_install_branch: master

handlers/main.yml

@@ -19,8 +19,8 @@
     - Restart cinder services
 
 - name: Reload upstart init scripts
-  shell: |
+  command: initctl reload-configuration
-    initctl reload-configuration
+  changed_when: false
   notify:
     - Restart cinder services
 

tasks/cinder_backends.yml

@@ -30,6 +30,7 @@
       {{ cinder_bin }}/cinder {{ keystone_service_adminuri_insecure | bool | ternary('--insecure','') }} type-key "{{ item.key }}" set volume_backend_name="{{ item.value.volume_backend_name }}"
     fi
   with_dict: "{{ cinder_backends|default({}) }}"
+  changed_when: false
 
 - name: Add extra cinder volume types
   shell: |

tasks/cinder_db_setup.yml

@@ -17,3 +17,4 @@
   command: "{{ cinder_bin }}/cinder-manage db sync"
   become: yes
   become_user: "{{ cinder_system_user_name }}"
+  changed_when: false

tasks/cinder_install.yml

@@ -54,7 +54,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ cinder_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ cinder_pip_package_state }}"
     extra_args: "{{ pip_install_options_fact }}"
   register: install_packages
   until: install_packages|success
@@ -127,7 +127,7 @@
 - name: Install pip packages
   pip:
     name: "{{ cinder_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ cinder_pip_package_state }}"
     virtualenv: "{{ cinder_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"

tasks/cinder_qos.yml

@@ -19,7 +19,8 @@
     {{ cinder_bin }}/cinder qos-list | grep {{ item.name }} || \
     {{ cinder_bin }}/cinder qos-create {{ item.name }}\
     {% for k,v in item.options.iteritems() %} {{ k }}={{ v }}{% endfor %}
-  with_items: cinder_qos_specs
+  with_items: "{{ cinder_qos_specs }}"
+  changed_when: false
   tags:
     - cinder-qos
 
@@ -31,7 +32,7 @@
       $({{ cinder_bin }}/cinder qos-list | grep {{ item.name }} | grep -oE "{{ _UUID_regex }}") \
       $({{ cinder_bin }}/cinder type-list | grep {{ vtype }} | grep -oE "{{ _UUID_regex }}")
     {% endfor %}
-  with_items: cinder_qos_specs
+  with_items: "{{ cinder_qos_specs }}"
   when:
     - item.cinder_volume_types is defined
   tags:

tasks/main.yml

@@ -27,6 +27,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always