openstack/openstack-ansible-os_keystone
Code Issues Proposed changes

Remove 'ignore_errors: true' in favor of 'failed_when: false'

Browse Source 
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.

It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.

Change-Id: I5ceece61312e2bf39d7489261bca247f353d6d74
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This commit is contained in:
Kevin Carter
2016-10-14 16:45:37 -05:00
parent 4d720c9d0e
commit 6c902fc471
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tasks/keystone_apache.yml
View File

@@ -94,7 +94,7 @@
apache2_module: apache2_module:
name: shib2 name: shib2
state: "{{ ( keystone_sp != {} ) | ternary('present', 'absent') }}" state: "{{ ( keystone_sp != {} ) | ternary('present', 'absent') }}"
ignore_errors: yes failed_when: false
when: when:
- ansible_pkg_mgr == 'apt' - ansible_pkg_mgr == 'apt'
notify: notify:

2
tasks/keystone_install.yml
View File

@@ -101,7 +101,7 @@
url: "{{ keystone_venv_download_url }}" url: "{{ keystone_venv_download_url }}"
dest: "/var/cache/{{ keystone_venv_download_url | basename }}" dest: "/var/cache/{{ keystone_venv_download_url | basename }}"
force: yes force: yes
ignore_errors: true failed_when: false
register: get_venv register: get_venv
when: when:
- not keystone_developer_mode | bool - not keystone_developer_mode | bool