openstack/openstack-ansible-os_rally
Code Issues Proposed changes

Remove 'ignore_errors: true' in favor of 'failed_when: false'

Browse Source 
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.

It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.

Change-Id: I5986a6588788b09501935fcd0fc18b96531bdca2
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This commit is contained in:
Kevin Carter 2016-10-14 16:46:03 -05:00
parent 16ac444076
commit 4cd19d9ce8
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tasks/database-setup.yml
View File

@ -15,7 +15,7 @@
- name: Check for db - name: Check for db
command: "{{ rally_bin }}/rally deployment list" command: "{{ rally_bin }}/rally deployment list"
ignore_errors: true failed_when: false
register: rally_deployment_list_result register: rally_deployment_list_result
- name: Create/upgrade Rally DB schema - name: Create/upgrade Rally DB schema
@ -25,7 +25,7 @@
- name: Check for existing Rally deployment - name: Check for existing Rally deployment
command: "{{ rally_bin }}/rally deployment list" command: "{{ rally_bin }}/rally deployment list"
ignore_errors: true failed_when: false
register: rally_deployment_list_result register: rally_deployment_list_result
- name: Setup the Rally deployment - name: Setup the Rally deployment

2
tasks/install.yml
View File

@ -85,7 +85,7 @@
url: "{{ rally_venv_download_url }}" url: "{{ rally_venv_download_url }}"
dest: "/var/cache/{{ rally_venv_download_url | basename }}" dest: "/var/cache/{{ rally_venv_download_url | basename }}"
force: yes force: yes
ignore_errors: true failed_when: false
register: get_venv register: get_venv
when: when:
- not rally_developer_mode | bool - not rally_developer_mode | bool