Optimise pip install tasks

Unlike the Ansible apt module, the Ansible pip module does not
recognise a with_items list and process all the items at once.

To optimise the pip install tasks, this patch replaces the use
of with_items with a join filter so that the pip install task
does an install with all the packages in a list, ensuring that
the execution is one action instead of many.

Change-Id: I403e36a67d2e06f5cd32fe28222b597a17ef42a1
This commit is contained in:
Jesse Pretorius 2016-07-18 16:23:59 +01:00
parent 32e3b2ad1f
commit 8b068b08fe

View File

@ -65,14 +65,13 @@
- name: Install requires pip packages
pip:
name: "{{ item }}"
name: "{{ rally_requires_pip_packages | join(' ') }}"
state: latest
extra_args: "{{ pip_install_options_fact }}"
register: install_packages
until: install_packages|success
retries: 5
delay: 2
with_items: rally_requires_pip_packages
tags:
- rally-install
- rally-pip-packages
@ -159,7 +158,7 @@
- name: Install pip packages
pip:
name: "{{ item }}"
name: "{{ rally_pip_packages | join(' ') }}"
state: latest
virtualenv: "{{ rally_bin | dirname }}"
virtualenv_site_packages: "no"
@ -168,7 +167,6 @@
until: install_packages|success
retries: 5
delay: 2
with_items: rally_pip_packages
when:
- rally_get_venv | failed or rally_developer_mode | bool
tags: