openstack/openstack-ansible-os_trove
Code Issues Proposed changes

Implement variables to address oslo.messaging improvements

Browse Source 
During last release cycle oslo.messaging has landed [1] series of extremely
useful changes that are designed to implement modern messaging
techniques for rabbitmq quorum queues.

Since these changes are breaking and require queues being re-created,
it makes total sense to align these with migration to quorum queues by default.

[1] https://review.opendev.org/q/topic:%22bug-2031497%22

Change-Id: Icd659cdf4c817d100668ab9c5639288b63078c38
This commit is contained in:
Dmitriy Rabotyagov 2024-05-02 19:34:34 +02:00 committed by Dmitriy Rabotyagov
parent 3a8a9da7b9
commit 4186873963
3 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
defaults/main.yml
View File

@ -161,9 +161,17 @@ trove_oslomsg_notify_policies: []
## RabbitMQ integration
trove_oslomsg_rabbit_quorum_queues: "{{ oslomsg_rabbit_quorum_queues | default(True) }}"
trove_oslomsg_rabbit_stream_fanout: "{{ oslomsg_rabbit_stream_fanout | default(trove_oslomsg_rabbit_quorum_queues) }}"
trove_oslomsg_rabbit_transient_quorum_queues: "{{ oslomsg_rabbit_transient_quorum_queues | default(trove_oslomsg_rabbit_stream_fanout) }}"
trove_oslomsg_rabbit_qos_prefetch_count: "{{ oslomsg_rabbit_qos_prefetch_count | default(trove_oslomsg_rabbit_stream_fanout | ternary(10, 0)) }}"
trove_oslomsg_rabbit_queue_manager: "{{ oslomsg_rabbit_queue_manager | default(trove_oslomsg_rabbit_quorum_queues) }}"
trove_oslomsg_rabbit_quorum_delivery_limit: "{{ oslomsg_rabbit_quorum_delivery_limit | default(0) }}"
trove_oslomsg_rabbit_quorum_max_memory_bytes: "{{ oslomsg_rabbit_quorum_max_memory_bytes | default(0) }}"
trove_guest_oslomsg_rabbit_quorum_queues: "{{ oslomsg_rabbit_quorum_queues | default(True) }}"
trove_guest_oslomsg_rabbit_stream_fanout: "{{ oslomsg_rabbit_stream_fanout | default(trove_guest_oslomsg_rabbit_quorum_queues) }}"
trove_guest_oslomsg_rabbit_transient_quorum_queues: "{{ oslomsg_rabbit_transient_quorum_queues | default(trove_guest_oslomsg_rabbit_stream_fanout) }}"
trove_guest_oslomsg_rabbit_qos_prefetch_count: "{{ oslomsg_rabbit_qos_prefetch_count | default(trove_guest_oslomsg_rabbit_stream_fanout | ternary(10, 0)) }}"
trove_guest_oslomsg_rabbit_queue_manager: "{{ oslomsg_rabbit_queue_manager | default(trove_guest_oslomsg_rabbit_quorum_queues) }}"
## Qdrouterd integration
# TODO(ansmith): Change structure when more backends will be supported

4
templates/trove-guestagent.conf.j2
View File

@ -32,6 +32,10 @@ user_domain_name = {{ trove_service_user_domain_name }}
# Deprecated group/name - [DEFAULT]/rabbit_use_ssl
ssl = {{ trove_guest_oslomsg_rpc_use_ssl }}
rabbit_quorum_queue = {{ trove_guest_oslomsg_rabbit_quorum_queues }}
rabbit_transient_quorum_queue = {{ trove_guest_oslomsg_rabbit_transient_quorum_queues }}
rabbit_qos_prefetch_count = {{ trove_guest_oslomsg_rabbit_qos_prefetch_count }}
use_queue_manager = {{ trove_guest_oslomsg_rabbit_queue_manager }}
rabbit_stream_fanout = {{ trove_guest_oslomsg_rabbit_stream_fanout }}
rabbit_quorum_delivery_limit = {{ trove_oslomsg_rabbit_quorum_delivery_limit }}
rabbit_quorum_max_memory_bytes = {{ trove_oslomsg_rabbit_quorum_max_memory_bytes }}

4
templates/trove.conf.j2
View File

@ -127,6 +127,10 @@ enabled = {{ trove_profiler_enabled }}
[oslo_messaging_rabbit]
ssl = {{ trove_oslomsg_rpc_use_ssl }}
rabbit_quorum_queue = {{ trove_oslomsg_rabbit_quorum_queues }}
rabbit_transient_quorum_queue = {{ trove_oslomsg_rabbit_transient_quorum_queues }}
rabbit_qos_prefetch_count = {{ trove_oslomsg_rabbit_qos_prefetch_count }}
use_queue_manager = {{ trove_oslomsg_rabbit_queue_manager }}
rabbit_stream_fanout = {{ trove_oslomsg_rabbit_stream_fanout }}
rabbit_quorum_delivery_limit = {{ trove_oslomsg_rabbit_quorum_delivery_limit }}
rabbit_quorum_max_memory_bytes = {{ trove_oslomsg_rabbit_quorum_max_memory_bytes }}