Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: I37ed27a28c0551af99a1f730b2b61d0ad1db4a3b

defaults/main.yml

@@ -15,7 +15,9 @@
 #
 # (c) 2016 Donovan Francesco <donovan.francesco@is.co.za>
 # (c) 2016 Paul Stevens <paul.stevens@is.co.za>
+
 trove_package_state: "latest"
+trove_pip_package_state: "latest"
 
 debug: false
 trove_system_group_name: trove

tasks/main.yml

@@ -29,6 +29,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always

tasks/trove_db_setup.yml

@@ -22,3 +22,4 @@
     db_sync {{ trove_db_sync_options }}
   become: yes
   become_user: "{{ trove_system_user_name }}"
+  changed_when: false

tasks/trove_init_upstart.yml

@@ -30,8 +30,7 @@
     - Restart Apache
 
 - name: Reload init scripts
-  shell: |
-    initctl reload-configuration
+  command: initctl reload-configuration
   when: upstart_init | changed
   notify:
     - Restart trove API services

tasks/trove_install.yml

@@ -55,7 +55,7 @@
 - name: Install required pip packages
   pip:
     name: "{{ trove_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ trove_pip_package_state }}"
     extra_args: "{{ pip_install_options_fact }}"
   register: install_packages
   until: install_packages|success
@@ -129,7 +129,7 @@
 - name: Install pip packages
   pip:
     name: "{{ trove_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ trove_pip_package_state }}"
     virtualenv: "{{ trove_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"