openstack/openstack-ansible-rabbitmq_server
Code Issues Proposed changes

Fix RPM warnings, cleanup

Browse Source 
This patch fixes the Ansible warnings about using RPM and it cleans
up a "when" to make it easier to read.

Change-Id: Iff27f90654a5b21a7e59d7cca4ed6e83cde74716
This commit is contained in:
Major Hayden 2017-06-21 07:42:45 -05:00
parent 83a95efda1
commit 0534bbf490
No known key found for this signature in database
GPG Key ID: 737051E0C1011FB1
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tasks/rabbitmq_upgrade_check.yml
View File

@ -17,8 +17,7 @@
# so we skip this task in the ansible-lint check by using the
# 'skip_ansible_lint' tag
- name: Get version of installed RabbitMQ package (deb)
shell: |
dpkg -l | grep rabbitmq-server
shell: "dpkg -l | grep rabbitmq-server"
failed_when: false
register: installed_rabbitmq_deb
when:
@ -33,8 +32,9 @@
# so we skip this task in the ansible-lint check by using the
# 'skip_ansible_lint' tag
- name: Get version of installed RabbitMQ package (rpm)
shell: |
rpm -qa | grep rabbitmq-server
shell: "rpm -qa | grep rabbitmq-server"
args:
warn: no
failed_when: false
register: installed_rabbitmq_rpm
when:
@ -48,7 +48,9 @@
- name: Register a fact for the installed RabbitMQ version
set_fact:
installed_rabbitmq: "{{ item }}"
when: not item | skipped and item | changed
when:
- not item | skipped
- item | changed
with_items:
- "{{ installed_rabbitmq_deb }}"
- "{{ installed_rabbitmq_rpm }}"