openstack/openstack-ansible-tests
Code Issues Proposed changes

Check for existance of ethtool and iproute2

Browse Source 
It's good to check for tools before launching them. The common practise
is used in openstack-ansible/scripts/log-collect.sh

Change-Id: I2b2866bb0ba36eb658da71fe0670d39b911d90c1
This commit is contained in:
Dmitriy Rabotyagov 2019-08-26 16:40:21 +03:00 committed by Dmitriy Rabotyagov (noonedeadpunk)
parent fcd6eb32b6
commit 11c26d2d4f
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test-log-collect.sh
View File

@ -280,13 +280,14 @@ sudo iptables -t nat -nvL > "${WORKING_DIR}/logs/iptables-nat.txt" || true
repo_information host
# Record the active interface configs
for interface in $(ip -o link | awk -F':' '{print $2}'); do
if which ethtool &> /dev/null; then
ethtool -k ${interface} > "${WORKING_DIR}/logs/ethtool-${interface}-cfg.txt" || true
else
echo "No ethtool available" | tee -a "${WORKING_DIR}/logs/ethtool-${interface}-cfg.txt"
fi
done
if which ethtool &> /dev/null && which ip &> /dev/null; then
for interface in $(ip -o link | awk -F':' '{print $2}' | sed 's/@.*//g'); do
echo "ethtool -k ${interface}"
ethtool -k ${interface} > "${WORKING_DIR}/logs/ethtool-${interface}-${TS}-cfg.txt" || true
done
else
echo "No ethtool or iproute2 available" | tee -a "${WORKING_DIR}/logs/ethtool-${TS}-${interface}-cfg.txt"
fi
# Compress the files gathered so that they do not take up too much space.
compress_files