openstack/openstack-ansible-tests
Code Issues Proposed changes

test-prepare-host: Switch package state to 'present' on openSUSE

Browse Source 
Similar to the CentOS case, we should use 'present' instead of 'latest'
for the package state so we don't spend time resolving dependencies,
querying repos etc. The 'present' state can be further improved either
in the zypper itself or in the Ansible module.

Change-Id: I44fae44030af1c9ee88dcc26c6b55c91a2531926
Link: https://github.com/ansible/ansible/pull/37191
Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1084525
This commit is contained in:
Markos Chandras 2018-03-08 15:35:16 +00:00
parent 96c01ad653
commit 1f2ab67987
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test-prepare-host.yml
View File

@ -42,12 +42,12 @@
with_items: with_items:
- "91.189.91.21 images.linuxcontainers.org us.images.linuxcontainers.org" - "91.189.91.21 images.linuxcontainers.org us.images.linuxcontainers.org"
- "91.189.88.37 images.linuxcontainers.org uk.images.linuxcontainers.org" - "91.189.88.37 images.linuxcontainers.org uk.images.linuxcontainers.org"
# NOTE(mhayden): Using package_state=present on CentOS 7 should allow for # NOTE(mhayden): Using package_state=present on CentOS or openSUSE should allow for
# more gate jobs to complete properly and expose more problems that can # more gate jobs to complete properly and expose more problems that can
# be fixed (instead of timeouts). # be fixed (instead of timeouts).
- name: Use present for package_state on CentOS 7 - name: Use present for package_state on CentOS and openSUSE
set_fact: set_fact:
package_state: "{{ (ansible_os_family == 'RedHat') | ternary('present', 'latest') }}" package_state: "{{ (ansible_pkg_mgr in ['dnf', 'yum', 'zypper']) | ternary('present', 'latest') }}"
- include: test-install-openstack-hosts.yml - include: test-install-openstack-hosts.yml