From d097c3bf24d01509d7eed63fcfacd9941f5c68fa Mon Sep 17 00:00:00 2001 From: "Ritchie, Frank (fr801x)" Date: Fri, 25 Aug 2023 14:32:00 -0400 Subject: [PATCH] Fix typo in selenium test For selenium v3 the proper syntax is link = browser.find_element_by_link_text(link_name) not link = browser.find_element_by_text_link(link_name) Change-Id: I9f6062bae5caaa840208e90e8f29b63bf52d113b --- nagios/Chart.yaml | 2 +- nagios/templates/bin/_selenium-tests.py.tpl | 2 +- releasenotes/notes/nagios.yaml | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/nagios/Chart.yaml b/nagios/Chart.yaml index 3da34708a..5bcff7561 100644 --- a/nagios/Chart.yaml +++ b/nagios/Chart.yaml @@ -15,7 +15,7 @@ apiVersion: v1 appVersion: v1.0.0 description: OpenStack-Helm Nagios name: nagios -version: 0.1.9 +version: 0.1.10 home: https://www.nagios.org sources: - https://opendev.org/openstack/openstack-helm-addons diff --git a/nagios/templates/bin/_selenium-tests.py.tpl b/nagios/templates/bin/_selenium-tests.py.tpl index 105d2db2a..81266a33b 100644 --- a/nagios/templates/bin/_selenium-tests.py.tpl +++ b/nagios/templates/bin/_selenium-tests.py.tpl @@ -56,7 +56,7 @@ def click_link_by_name(link_name): {{- if .Values.selenium_v4 }} link = browser.find_element(By.LINK_TEXT, link_name) {{- else }} - link = browser.find_element_by_text_link(link_name) + link = browser.find_element_by_link_text(link_name) {{- end }} link.click() except NoSuchElementException: diff --git a/releasenotes/notes/nagios.yaml b/releasenotes/notes/nagios.yaml index 2bb86d921..1c8529923 100644 --- a/releasenotes/notes/nagios.yaml +++ b/releasenotes/notes/nagios.yaml @@ -10,4 +10,5 @@ nagios: - 0.1.7 Upgrade osh-selenium image to latest-ubuntu_focal - 0.1.8 Use helm toolkit for readiness probes - 0.1.9 Make using selenium v4 syntax optional + - 0.1.10 Correct selenium v3 syntax ...