openstack/openstack-manuals
Code Issues Proposed changes

Fix book building

Browse Source 
The args parameter to apply_async really needs to be (book, ), otherwise
nothing is passed and no books are build.

Change-Id: Icae89df5734b1be58f0e6ec8aecc1a31aef365f4
This commit is contained in:
Andreas Jaeger 2013-09-23 19:28:47 +02:00
parent dcc2a35153
commit 4c5a96384b
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/test.py
View File

@ -457,10 +457,10 @@ def build_affected_books(rootdir, book_exceptions, file_exceptions,
print("Queuing the following books for building:")
for book in books:
print(" %s" % os.path.basename(book))
pool.apply_async(build_book, book,
pool.apply_async(build_book, (book, ),
callback=logging_build_book)
pool.close()
print("Building all books now...")
print("Building all queued %d books now..." % len(books))
pool.join()
any_failures = False

5
tools/validate.py
View File

@ -452,10 +452,10 @@ def build_affected_books(rootdir, book_exceptions, file_exceptions, force):
print("Queuing the following books for building:")
for book in books:
print(" %s" % os.path.basename(book))
pool.apply_async(build_book, book,
pool.apply_async(build_book, (book, ),
callback=logging_build_book)
pool.close()
print("Building all queued books now...")
print("Building all queued %d books now..." % len(books))
pool.join()
any_failures = False
@ -467,7 +467,6 @@ def build_affected_books(rootdir, book_exceptions, file_exceptions, force):
print(">>> Build of book %s failed (returncode = %d)."
% (book, returncode))
print("\n%s" % output)
if any_failures:
sys.exit(1)