openstack/openstacksdk
Code Issues Proposed changes

stack event loops: handle get None result

Browse Source 
We've seen at least one case in CI of `stack` being None when polling
for stack events:

    <snip>
      File "openstack/cloud/_orchestration.py", line 185, in delete_stack
        event_utils.poll_for_events(
      File "openstack/orchestration/util/event_utils.py", line 109,
      in poll_for_events
        stack_status = stack['stack_status']
    TypeError: 'NoneType' object is not subscriptable

Handle this case with a simple if.

Change-Id: Icce6e7b600125cf98e56d98e1c3df4177414398b
This commit is contained in:
Artom Lifshitz
2024-08-30 09:56:16 -04:00
parent b65b7d4d3e
commit 2ea501c069
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
openstack/orchestration/util/event_utils.py
View File

@@ -106,6 +106,7 @@ def poll_for_events(
if no_event_polls >= 2:
# after 2 polls with no events, fall back to a stack get
stack = cloud.get_stack(stack_name, resolve_outputs=False)
if stack:
stack_status = stack['stack_status']
msg = msg_template % dict(name=stack_name, status=stack_status)
if stop_check(stack_status):