openstack/openstacksdk
Code Issues Proposed changes

Remove loop variable

Browse Source 
Ironic have changed an API response without a microversion :(

We must also bump the lower-constraint of os-service-types, since we
have a test that verifies that we are using the latest and greatest
version.

Change-Id: I1e7ac6fbf70519190f1e51c0d8651cc5f4a776fc
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane
2025-07-10 11:48:46 +01:00
parent 83fc95d25b
commit 82bc005071
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
openstack/tests/functional/baremetal/test_baremetal_inspection_rules.py
View File

@@ -169,7 +169,6 @@ class TestBareMetalInspectionRule(base.BaseBaremetalTest):
updated_actions = [ updated_actions = [
{ {
"op": "set-attribute", "op": "set-attribute",
"loop": [],
"args": ["/driver", "fake"], "args": ["/driver", "fake"],
} }
] ]

5
openstack/tests/unit/test_utils.py
View File

@@ -223,13 +223,12 @@ class TestMaximumSupportedMicroversion(base.TestCase):
class TestOsServiceTypesVersion(base.TestCase): class TestOsServiceTypesVersion(base.TestCase):
def test_ost_version(self): def test_ost_version(self):
ost_version = '2019-05-01T19:53:21.498745' ost_version = '2022-09-13T15:34:32.154125'
self.assertEqual( self.assertEqual(
ost_version, ost_version,
os_service_types.ServiceTypes().version, os_service_types.ServiceTypes().version,
"This project must be pinned to the latest version of " "This project must be pinned to the latest version of "
"os-service-types. Please bump requirements.txt and " "os-service-types. Please bump requirements.txt accordingly.",
"lower-constraints.txt accordingly.",
) )

2
requirements.txt
View File

@@ -5,7 +5,7 @@ iso8601>=0.1.11 # MIT
jmespath>=0.9.0 # MIT jmespath>=0.9.0 # MIT
jsonpatch!=1.20,>=1.16 # BSD jsonpatch!=1.20,>=1.16 # BSD
keystoneauth1>=5.10.0 # Apache-2.0 keystoneauth1>=5.10.0 # Apache-2.0
os-service-types>=1.7.0 # Apache-2.0 os-service-types>=1.8.0 # Apache-2.0
pbr!=2.1.0,>=2.0.0 # Apache-2.0 pbr!=2.1.0,>=2.0.0 # Apache-2.0
platformdirs>=3 # MIT License platformdirs>=3 # MIT License
psutil>=3.2.2 # BSD psutil>=3.2.2 # BSD