openstack/openstacksdk
Code Issues Proposed changes

deps: Bump minimum keystoneauth

Browse Source 
We want typing.

Change-Id: I83cff62f92f942257f178921a6b94d49f25c69c9
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane
2025-02-24 16:00:29 +00:00
parent b3e1951997
commit fbebf106a5
4 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.pre-commit-config.yaml
View File

@@ -36,7 +36,7 @@ repos:
hooks: hooks:
- id: mypy - id: mypy
additional_dependencies: additional_dependencies:
- keystoneauth1 - keystoneauth1>=5.10.0
- types-decorator - types-decorator
- types-PyYAML - types-PyYAML
- types-requests - types-requests

6
openstack/utils.py
View File

@@ -212,7 +212,7 @@ def supports_microversion(
f'Required microversion {microversion} is higher than ' f'Required microversion {microversion} is higher than '
f'currently selected {adapter.default_microversion}' f'currently selected {adapter.default_microversion}'
) )
return supports # type: ignore[no-any-return] return supports
return True return True
@@ -276,7 +276,7 @@ def pick_microversion(
'Requested microversion is not supported by the server side ' 'Requested microversion is not supported by the server side '
'or the default microversion is too low' 'or the default microversion is too low'
) )
return discover.version_to_string(required_normalized) # type: ignore[no-any-return] return discover.version_to_string(required_normalized)
def maximum_supported_microversion( def maximum_supported_microversion(
@@ -327,7 +327,7 @@ def maximum_supported_microversion(
return None return None
result = min(client_max, server_max) result = min(client_max, server_max)
return discover.version_to_string(result) # type: ignore[no-any-return] return discover.version_to_string(result)
def _hashes_up_to_date( def _hashes_up_to_date(

3
pyproject.toml
View File

@@ -5,8 +5,7 @@ show_error_context = true
ignore_missing_imports = true ignore_missing_imports = true
follow_imports = "normal" follow_imports = "normal"
check_untyped_defs = true check_untyped_defs = true
# TODO(stephenfin): Remove this when typed keystoneauth1 (5.10.0?) is released warn_unused_ignores = true
warn_unused_ignores = false
# many of the following are false while we incrementally add typing # many of the following are false while we incrementally add typing
warn_return_any = false warn_return_any = false
warn_unused_configs = true warn_unused_configs = true

2
requirements.txt
View File

@@ -4,7 +4,7 @@ dogpile.cache>=0.6.5 # BSD
iso8601>=0.1.11 # MIT iso8601>=0.1.11 # MIT
jmespath>=0.9.0 # MIT jmespath>=0.9.0 # MIT
jsonpatch!=1.20,>=1.16 # BSD jsonpatch!=1.20,>=1.16 # BSD
keystoneauth1>=3.18.0 # Apache-2.0 keystoneauth1>=5.10.0 # Apache-2.0
os-service-types>=1.7.0 # Apache-2.0 os-service-types>=1.7.0 # Apache-2.0
pbr!=2.1.0,>=2.0.0 # Apache-2.0 pbr!=2.1.0,>=2.0.0 # Apache-2.0
platformdirs>=3 # MIT License platformdirs>=3 # MIT License