openstack/oslo.db
Code Issues Proposed changes

Avoid excessing logging of RetryRequest exception

Browse Source 
Such exception indicates of error condition only if
retries are exceeded. In other cases error-level logs
pollute the log file and complicate log analysis.

Change-Id: I318867043a68a6499851631593859a0fffac6038
Closes-Bug: #1433001
This commit is contained in:
Eugene Nikanorov 2015-03-17 14:17:41 +03:00
parent de9439c457
commit 02aeda28cf
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
oslo_db/api.py
View File

@ -139,7 +139,11 @@ class wrap_db_retry(object):
raise e raise e
if remaining != -1: if remaining != -1:
remaining -= 1 remaining -= 1
LOG.exception(_LE('DB error.')) # RetryRequest is application-initated exception
# and not an error condition in case retries are
# not exceeded
if not isinstance(e, exception.RetryRequest):
LOG.exception(_LE('DB error.'))
# NOTE(vsergeyev): We are using patched time module, so # NOTE(vsergeyev): We are using patched time module, so
# this effectively yields the execution # this effectively yields the execution
# context to another green thread. # context to another green thread.