openstack/oslo.db
Code Issues Proposed changes

Don't sleep in tests

Browse Source 
Mock it out, reducing test run of ~3 and ~15 seconds to milliseconds.

Change-Id: Ice3a0c0d0a5b8c2920c7f775ff8ce974b572c66e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2023-03-22 12:22:03 +00:00
parent 481936a822
commit 672dd056aa
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
oslo_db/tests/test_api.py
View File

@ -210,7 +210,8 @@ class DBRetryRequestCase(DBAPITestCase):
some_method()
def test_retry_wrapper_reaches_limit(self):
@mock.patch('oslo_db.api.time.sleep', return_value=None)
def test_retry_wrapper_reaches_limit(self, mock_sleep):
max_retries = 2
@api.wrap_db_retry(max_retries=max_retries)
@ -222,7 +223,8 @@ class DBRetryRequestCase(DBAPITestCase):
self.assertRaises(ValueError, some_method, res)
self.assertEqual(max_retries + 1, res['result'])
def test_retry_wrapper_exception_checker(self):
@mock.patch('oslo_db.api.time.sleep', return_value=None)
def test_retry_wrapper_exception_checker(self, mock_sleep):
def exception_checker(exc):
return isinstance(exc, ValueError) and exc.args[0] < 5