openstack/oslo.messaging
Code Issues Proposed changes

Use a for loop to set the defaults for __call__ params

Browse Source 
Instead of setting the default kwargs based on a repeated
setdefault() call, just use a for loop to set the defaults.

Change-Id: I5c7fd22856912545bf5f95fd07568375dbecbe5b
This commit is contained in:
Joshua Harlow 2014-04-09 17:34:08 -07:00
parent c90581937c
commit 0c4a564d9c
1 changed files with 3 additions and 6 deletions

9
oslo/messaging/target.py

@ -69,12 +69,9 @@ class Target(object):
self.fanout = fanout
def __call__(self, **kwargs):
kwargs.setdefault('exchange', self.exchange)
kwargs.setdefault('topic', self.topic)
kwargs.setdefault('namespace', self.namespace)
kwargs.setdefault('version', self.version)
kwargs.setdefault('server', self.server)
kwargs.setdefault('fanout', self.fanout)
for a in ('exchange', 'topic', 'namespace',
'version', 'server', 'fanout'):
kwargs.setdefault(a, getattr(self, a))
return Target(**kwargs)
def __eq__(self, other):