openstack/oslo.messaging
Code Issues Proposed changes

Knock off a few TODOs

Browse Source
This commit is contained in:
Mark McLoughlin 2013-06-16 09:47:18 +01:00
parent 293a34c156
commit 563383b51d
1 changed files with 0 additions and 9 deletions

9
doc/messaging/notes.txt

@ -1,14 +1,10 @@
TODO: TODO:
- can_send_version() in RPCClient
- we need some way for the dispatcher to take the incoming - we need some way for the dispatcher to take the incoming
context dict and instantiate a user-supplied request context context dict and instantiate a user-supplied request context
object with it object with it
- notifications!
- @expose decorator - @expose decorator
- when shutting down a dispatcher, do we need to invoke - when shutting down a dispatcher, do we need to invoke
@ -17,8 +13,6 @@ TODO:
- ClientException - e.g. the executor should handle this being - ClientException - e.g. the executor should handle this being
raised by the dispatcher raised by the dispatcher
- raising Timeout when a reply isn't received
- the InvalidTarget checks seem like they're generic preconditions - the InvalidTarget checks seem like they're generic preconditions
that all drivers would want enforced that all drivers would want enforced
@ -30,9 +24,6 @@ TODO:
sure the context of the currently dispatching rpc is available to sure the context of the currently dispatching rpc is available to
logging. Need to abstract out the dependency on eventlet for this. logging. Need to abstract out the dependency on eventlet for this.
- the current rpc code dispatches each method in its own greenlet,
we need to do the same in the eventlet executor
- I'm not sure listener.done() is really needed - can't we ack the - I'm not sure listener.done() is really needed - can't we ack the
message before returning it from poll() ? message before returning it from poll() ?