openstack/oslo.messaging
Code Issues Proposed changes

Fix aliases deprecation

Browse Source 
We log deprecation message even if application doesn't use it.
And we missing the parse method.

This change fixes that.

Change-Id: I476816cb14ac8218feb74e8459cfa5f18fdb6c61
This commit is contained in:
Mehdi Abaakouk 2017-04-27 12:21:28 +02:00
parent 83e738c2fd
commit 7a6474662d
1 changed files with 7 additions and 2 deletions

9
oslo_messaging/transport.py

@ -365,6 +365,8 @@ class TransportURL(object):
return url
@removals.removed_kwarg('aliases',
'Parameter aliases is deprecated for removal.')
@classmethod
def parse(cls, conf, url=None, aliases=None):
"""Parse an url.
@ -404,7 +406,7 @@ class TransportURL(object):
conf.register_opts(_transport_opts)
url = url or conf.transport_url
if not url:
return cls(conf, aliases=aliases)
return cls(conf) if aliases is None else cls(conf, aliases=aliases)
if not isinstance(url, six.string_types):
raise InvalidTransportURL(url, 'Wrong URL type')
@ -488,4 +490,7 @@ class TransportURL(object):
{'hosts_with_credentials': hosts_with_credentials,
'hosts_without_credentials':
hosts_without_credentials})
return cls(conf, transport, virtual_host, hosts, aliases, query)
if aliases is None:
return cls(conf, transport, virtual_host, hosts, query=query)
else:
return cls(conf, transport, virtual_host, hosts, aliases, query)