From a704a3f1fcbb0e357d2fead8405c03c7586fa197 Mon Sep 17 00:00:00 2001
From: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Date: Tue, 24 Jun 2014 11:07:20 +0900
Subject: [PATCH] Use assertEqual instead of assertIs for strings
Checking identity of strings is not a great idea.
It might not work with different implementations. (eg. pypy)
Test usual equality instead.
Change-Id: Ib1a673a0ac116f2c80d066e94a8bd9a9ef8f518a
---
tests/notify/test_listener.py | 2 +-
tests/rpc/test_server.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/notify/test_listener.py b/tests/notify/test_listener.py
index cd0e4c448..8f0c30918 100644
--- a/tests/notify/test_listener.py
+++ b/tests/notify/test_listener.py
@@ -92,7 +92,7 @@ class TestNotifyListener(test_utils.BaseTestCase, ListenerSetupMixin):
self.assertIsInstance(listener.dispatcher,
dispatcher.NotificationDispatcher)
self.assertIs(listener.dispatcher.endpoints, endpoints)
- self.assertIs(listener.executor, 'blocking')
+ self.assertEqual('blocking', listener.executor)
def test_no_target_topic(self):
transport = messaging.get_transport(self.conf, url='fake:')
diff --git a/tests/rpc/test_server.py b/tests/rpc/test_server.py
index 5a1308154..f4f5120c5 100644
--- a/tests/rpc/test_server.py
+++ b/tests/rpc/test_server.py
@@ -108,7 +108,7 @@ class TestRPCServer(test_utils.BaseTestCase, ServerSetupMixin):
self.assertIsInstance(server.dispatcher, messaging.RPCDispatcher)
self.assertIs(server.dispatcher.endpoints, endpoints)
self.assertIs(server.dispatcher.serializer, serializer)
- self.assertIs(server.executor, 'blocking')
+ self.assertEqual('blocking', server.executor)
def test_no_target_server(self):
transport = messaging.get_transport(self.conf, url='fake:')