From b516271a8005a4f13c41c3b338d14667bb73a333 Mon Sep 17 00:00:00 2001
From: Mark McLoughlin <markmc@redhat.com>
Date: Thu, 1 Aug 2013 22:35:26 +0100
Subject: [PATCH] Remove some FIXMEs and debug logging
These FIXMEs don't need fixing now that I think it through some more.
The reply format is specific to drivers and the 'ending' flag is part of
the existing wire protocol that we need to support even if we don't
support multicall().
Change-Id: I834f0bb01513b5318f0b365948a7d9247feb49bf
---
oslo/messaging/_drivers/amqpdriver.py | 4 ----
1 file changed, 4 deletions(-)
diff --git a/oslo/messaging/_drivers/amqpdriver.py b/oslo/messaging/_drivers/amqpdriver.py
index f9fc768b3..fca9105cf 100644
--- a/oslo/messaging/_drivers/amqpdriver.py
+++ b/oslo/messaging/_drivers/amqpdriver.py
@@ -41,10 +41,7 @@ class AMQPIncomingMessage(base.IncomingMessage):
if failure:
failure = rpc_common.serialize_remote_exception(failure)
- # FIXME(markmc): is the reply format really driver specific?
msg = {'result': reply, 'failure': failure}
-
- # FIXME(markmc): given that we're not supporting multicall ...
if ending:
msg['ending'] = True
@@ -60,7 +57,6 @@ class AMQPIncomingMessage(base.IncomingMessage):
conn.direct_send(self.msg_id, rpc_common.serialize_msg(msg))
def reply(self, reply=None, failure=None):
- LOG.info("reply")
with self.listener.driver._get_connection() as conn:
self._send_reply(conn, reply, failure)
self._send_reply(conn, ending=True)