openstack/oslo.messaging
Code Issues Proposed changes

sort when using groupby

Browse Source 
groupby requires items to be sorted as it's clumping consecutive
items together. also, just use itemgetter instead of lambda

Change-Id: I1676fc60ebc2c9ff03ea00cc67061fdfb3b50868
This commit is contained in:
gord chung 2017-11-25 19:23:55 -05:00
parent 02056bfb12
commit b8a686fc52
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
oslo_messaging/notify/dispatcher.py
View File

@ -16,6 +16,7 @@
import itertools
import logging
import operator
import six
@ -118,9 +119,9 @@ class BatchNotificationDispatcher(NotificationDispatcher):
"""Dispatch notification messages to the appropriate endpoint method.
"""
messages_grouped = itertools.groupby((
self._extract_user_message(m)
for m in incoming), lambda x: x[0])
messages_grouped = itertools.groupby(sorted(
(self._extract_user_message(m) for m in incoming),
key=operator.itemgetter(0)), operator.itemgetter(0))
requeues = set()
for priority, messages in messages_grouped: