openstack/oslo.messaging
Code Issues Proposed changes

rabbit: Don't prefetch when batch_size is set

Browse Source 
When the application set batch_size, so we don't need to prefetch more
messages, especially for notifications. Notifications queues can be
really big when the consumer have disapear during a long period, and
when it come back, kombu/pyamqp will fetch all messages it can. So we
override the qos prefetch value.

Change-Id: I601e10cf94310b9f96f7acb9942959aaafad7994
Closes-bug: #1551667
This commit is contained in:
Mehdi Abaakouk 2016-10-11 18:03:32 +02:00
parent 7ab113231b
commit c881baed29
1 changed files with 6 additions and 0 deletions

6
oslo_messaging/_drivers/amqpdriver.py

@ -487,6 +487,12 @@ class AMQPDriverBase(base.BaseDriver):
def listen_for_notifications(self, targets_and_priorities, pool,
batch_size, batch_timeout):
conn = self._get_connection(rpc_common.PURPOSE_LISTEN)
# NOTE(sileht): The application set batch_size, so we don't need to
# prefetch more messages, especially for notifications. Notifications
# queues can be really big when the consumer have disapear during a
# long period, and when it come back, kombu/pyamqp will fetch all
# messages it can. So we override the default qos prefetch value
conn.connection.rabbit_qos_prefetch_count = batch_size
listener = AMQPListener(self, conn)
for target, priority in targets_and_priorities: