openstack/oslo.messaging
Code Issues Proposed changes

Remove deprecation of heartbeat_in_pthread

Browse Source 
In some circumstances services can be executed outside of mod_wsgi and
in a monkey patched environment. In this context we need to leave the
possibility to users to execute the heartbeat in a green thread.

The heartbeat_in_pthread was tagged as depreacted few months and planned
for a future removal. These changes drop this deprecation to allow to
enable green threads if needed.

Closes-Bug: #1934937
Change-Id: Iee2e5a6f7d71acba70bbc857f0bd7d83e32a7b8c
This commit is contained in:
Hervé Beraud
2021-07-13 12:50:48 +02:00
parent 9ab3f4f30d
commit d24edef117
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
oslo_messaging/_drivers/impl_rabbit.py
View File

@@ -97,7 +97,7 @@ rabbit_opts = [
"example if the parent process has monkey patched the " "example if the parent process has monkey patched the "
"stdlib by using eventlet/greenlet then the heartbeat " "stdlib by using eventlet/greenlet then the heartbeat "
"will be run through a green thread.", "will be run through a green thread.",
deprecated_for_removal=True), ),
cfg.FloatOpt('kombu_reconnect_delay', cfg.FloatOpt('kombu_reconnect_delay',
default=1.0, default=1.0,
deprecated_group='DEFAULT', deprecated_group='DEFAULT',

6
releasenotes/notes/undeprecate_heartbeat_in_pthread-48e2c1fc008cf208.yaml Normal file
View File

@@ -0,0 +1,6 @@
---
upgrade:
- |
We undeprecated the ``heartbeat_in_pthread`` option. This option will
remain available to allow customers to run the rabbitmq heartbeat in
python thread or not.