openstack/oslo.messaging
Code Issues Proposed changes

Fix simulator bool command line args

Browse Source 
--debug, --is-cast and --is-fanout are defined as args of type=bool.
This means that, for example, if we want to enable debug logging
level, we have to type '--debug True'. But we can also use
'--debug False' in order to do the same, which is very misleading
(in fact, any non-empty string will evaluate to True). This patch
tries to solve this problem by replacing type=bool and
default=False with action='store_true' for these args, so that
we will be able to enable them (they will remain False by default
as before) simply as '--debug' etc.

Change-Id: I8ee04c35427df446966161491da8d264b44975bf
This commit is contained in:
Gevorg Davoian 2016-09-30 12:27:08 +03:00
parent 16820d91b1
commit e491573654
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/simulator.py
View File

@ -601,8 +601,7 @@ def main():
parser.add_argument('--url', dest='url', parser.add_argument('--url', dest='url',
default='rabbit://guest:password@localhost/', default='rabbit://guest:password@localhost/',
help="oslo.messaging transport url") help="oslo.messaging transport url")
parser.add_argument('-d', '--debug', dest='debug', type=bool, parser.add_argument('-d', '--debug', dest='debug', action='store_true',
default=False,
help="Turn on DEBUG logging level instead of WARN") help="Turn on DEBUG logging level instead of WARN")
parser.add_argument('-tp', '--topic', dest='topic', parser.add_argument('-tp', '--topic', dest='topic',
default="profiler_topic", default="profiler_topic",
@ -659,10 +658,10 @@ def main():
client.add_argument('--exit-wait', dest='exit_wait', type=int, default=0, client.add_argument('--exit-wait', dest='exit_wait', type=int, default=0,
help='Keep connections open N seconds after calls ' help='Keep connections open N seconds after calls '
'have been done') 'have been done')
client.add_argument('--is-cast', dest='is_cast', type=bool, default=False, client.add_argument('--is-cast', dest='is_cast', action='store_true',
help='Use `call` or `cast` RPC methods') help='Use `call` or `cast` RPC methods')
client.add_argument('--is-fanout', dest='is_fanout', type=bool, client.add_argument('--is-fanout', dest='is_fanout', action='store_true',
default=False, help='fanout=True for CAST messages') help='fanout=True for CAST messages')
args = parser.parse_args() args = parser.parse_args()