From e5aceb351cce4c141765bc9d06292526bf12d90b Mon Sep 17 00:00:00 2001 From: melissaml <ma.lei@99cloud.net> Date: Thu, 20 Oct 2016 23:46:00 +0800 Subject: [PATCH] Using assertIsNone() instead of assertEqual(None) Following OpenStack Style Guidelines[1]: http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises [H203] Unit test assertions tend to give better messages for more specific assertions. As a result, assertIsNone(...) is preferred over assertEqual(None, ...) Change-Id: I192e339fadc6b738714697d1ae8673ebfb7abd79 --- oslo_messaging/tests/drivers/zmq/test_zmq_ttl_cache.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/oslo_messaging/tests/drivers/zmq/test_zmq_ttl_cache.py b/oslo_messaging/tests/drivers/zmq/test_zmq_ttl_cache.py index dd041c94a..772a97ded 100644 --- a/oslo_messaging/tests/drivers/zmq/test_zmq_ttl_cache.py +++ b/oslo_messaging/tests/drivers/zmq/test_zmq_ttl_cache.py @@ -42,7 +42,7 @@ class TestZmqTTLCache(test_utils.BaseTestCase): self.assertEqual(self.cache.get('x'), 'a') self.assertEqual(self.cache.get('x', 'b'), 'a') - self.assertEqual(self.cache.get('y'), None) + self.assertIsNone(self.cache.get('y')) self.assertEqual(self.cache.get('y', 'b'), 'b') time.sleep(1)