Fix notification tests not unmocking logging
Right now two tests mock logging module globally which leads to another test failure (TestRoutingNotifier.test_notify_filtered) on my env. Change-Id: Ifa47ee96dae79ea44dbe17a2d125401589ff13dd
This commit is contained in:
parent
b3893c13bd
commit
eb4f5c4fa0
@ -319,6 +319,8 @@ class TestLogNotifier(test_utils.BaseTestCase):
|
|||||||
|
|
||||||
mock_utcnow.return_value = datetime.datetime.utcnow()
|
mock_utcnow.return_value = datetime.datetime.utcnow()
|
||||||
|
|
||||||
|
logger = mock.Mock()
|
||||||
|
|
||||||
message = {
|
message = {
|
||||||
'message_id': str(message_id),
|
'message_id': str(message_id),
|
||||||
'publisher_id': 'test.localhost',
|
'publisher_id': 'test.localhost',
|
||||||
@ -328,15 +330,15 @@ class TestLogNotifier(test_utils.BaseTestCase):
|
|||||||
'timestamp': str(timeutils.utcnow()),
|
'timestamp': str(timeutils.utcnow()),
|
||||||
}
|
}
|
||||||
|
|
||||||
logger = mock.Mock()
|
with mock.patch.object(logging, 'getLogger') as gl:
|
||||||
logging.getLogger = mock.Mock()
|
gl.return_value = logger
|
||||||
logging.getLogger.return_value = logger
|
|
||||||
|
|
||||||
notifier.info({}, 'test.notify', 'bar')
|
notifier.info({}, 'test.notify', 'bar')
|
||||||
|
|
||||||
|
uuid.uuid4.assert_called_once_with()
|
||||||
|
logging.getLogger.assert_called_once_with(
|
||||||
|
'oslo.messaging.notification.test.notify')
|
||||||
|
|
||||||
uuid.uuid4.assert_called_once_with()
|
|
||||||
logging.getLogger.assert_called_once_with('oslo.messaging.'
|
|
||||||
'notification.test.notify')
|
|
||||||
logger.info.assert_called_once_with(JsonMessageMatcher(message))
|
logger.info.assert_called_once_with(JsonMessageMatcher(message))
|
||||||
|
|
||||||
self.assertTrue(notifier.is_enabled())
|
self.assertTrue(notifier.is_enabled())
|
||||||
@ -349,14 +351,15 @@ class TestLogNotifier(test_utils.BaseTestCase):
|
|||||||
'notification.foo'))
|
'notification.foo'))
|
||||||
logger.sample = None
|
logger.sample = None
|
||||||
|
|
||||||
logging.getLogger = mock.Mock()
|
|
||||||
logging.getLogger.return_value = logger
|
|
||||||
|
|
||||||
msg = {'event_type': 'foo'}
|
msg = {'event_type': 'foo'}
|
||||||
driver.notify(None, msg, "sample", None)
|
|
||||||
|
|
||||||
logging.getLogger.assert_called_once_with('oslo.messaging.'
|
with mock.patch.object(logging, 'getLogger') as gl:
|
||||||
'notification.foo')
|
gl.return_value = logger
|
||||||
|
|
||||||
|
driver.notify(None, msg, "sample", None)
|
||||||
|
|
||||||
|
logging.getLogger.assert_called_once_with('oslo.messaging.'
|
||||||
|
'notification.foo')
|
||||||
|
|
||||||
def test_mask_passwords(self):
|
def test_mask_passwords(self):
|
||||||
# Ensure that passwords are masked with notifications
|
# Ensure that passwords are masked with notifications
|
||||||
|
Loading…
x
Reference in New Issue
Block a user