openstack/oslo.vmware
Code Issues Proposed changes

When looping call fails do not log the exception trace

Browse Source 
This makes debugging terribly difficult when there are random
legitimate errors, for example a file is not found.

Change-Id: Iec76b95a70552de8e27683c0ea388b55b519db9f
This commit is contained in:
Gary Kotton 2019-04-08 01:16:04 -07:00 committed by garyk
parent 2a8b07b499
commit b6b6e7bdd4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
oslo_vmware/common/loopingcall.py
View File

@ -85,8 +85,9 @@ class FixedIntervalLoopingCall(LoopingCallBase):
except LoopingCallDone as e:
self.stop()
done.send(e.retvalue)
except Exception:
LOG.exception('in fixed duration looping call')
except Exception as e:
LOG.error('in fixed duration looping call. Error: %s',
str(e))
done.send_exception(*sys.exc_info())
return
else: