openstack/ovsdbapp
Code Issues Proposed changes

Merge "Ensure LrpAddCommand may_exits works without peers"

Browse Source
This commit is contained in:
Zuul 2023-05-30 14:23:22 +00:00 committed by Gerrit Code Review
commit d542e5cee1
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ovsdbapp/schema/ovn_northbound/commands.py
View File

@ -853,7 +853,7 @@ class LrpAddCommand(cmd.BaseCommand):
self.networks = [str(netaddr.IPNetwork(net)) for net in networks]
self.router = router
self.port = port
self.peer = peer
self.peer = peer if peer else []
self.may_exist = may_exist
self.columns = columns
super().__init__(api)

4
ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py
View File

@ -1384,7 +1384,7 @@ class TestLogicalRouterPortOps(OvnNorthboundTest):
def test_lrp_add(self):
self._lrp_add(None, 'de:ad:be:ef:4d:ad', ['192.0.2.0/24'])
def test_lpr_add_peer(self):
def test_lrp_add_peer(self):
lrp = self._lrp_add(None, 'de:ad:be:ef:4d:ad', ['192.0.2.0/24'],
peer='fake_peer')
self.assertIn('fake_peer', lrp.peer)
@ -1415,7 +1415,7 @@ class TestLogicalRouterPortOps(OvnNorthboundTest):
name = utils.get_rand_device_name()
args = (name, 'de:ad:be:ef:4d:ad', ['192.0.2.0/24'])
self._lrp_add(*args)
self.assertRaises(RuntimeError, self._lrp_add, *args, may_exist=True)
self._lrp_add(*args, may_exist=True)
def test_lrp_add_may_exist_different_router(self):
name = utils.get_rand_device_name()