Merge "Validate ensure parameter for package resources"

manifests/api.pp

@@ -55,8 +55,8 @@
 class aodh::api (
   Boolean $manage_service                 = true,
   Boolean $enabled                        = true,
-  $package_ensure                 = 'present',
-  $service_name                   = $aodh::params::api_service_name,
+  Stdlib::Ensure::Package $package_ensure = 'present',
+  String[1] $service_name                 = $aodh::params::api_service_name,
   Boolean $sync_db                        = false,
   $auth_strategy                          = 'keystone',
   $enable_proxy_headers_parsing           = $facts['os_service_default'],

manifests/evaluator.pp

@@ -33,7 +33,7 @@
 class aodh::evaluator (
   Boolean $manage_service                 = true,
   Boolean $enabled                        = true,
-  $package_ensure           = 'present',
+  Stdlib::Ensure::Package $package_ensure = 'present',
   $workers                                = $facts['os_workers'],
   $evaluation_interval                    = $facts['os_service_default'],
   $event_alarm_cache_ttl                  = $facts['os_service_default'],

manifests/expirer.pp

@@ -40,7 +40,7 @@
 #
 class aodh::expirer (
   Enum['present', 'absent'] $ensure       = 'present',
-  $package_ensure                    = 'present',
+  Stdlib::Ensure::Package $package_ensure = 'present',
   $minute                                 = 1,
   $hour                                   = 0,
   $monthday                               = '*',

manifests/init.pp

@@ -190,7 +190,7 @@
 #   Defaults to false.
 #
 class aodh (
-  $package_ensure                     = 'present',
+  Stdlib::Ensure::Package $package_ensure = 'present',
   $alarm_history_time_to_live             = $facts['os_service_default'],
   $lock_path                              = $facts['os_service_default'],
   $executor_thread_pool_size              = $facts['os_service_default'],

manifests/listener.pp

@@ -33,7 +33,7 @@
 class aodh::listener (
   Boolean $manage_service                 = true,
   Boolean $enabled                        = true,
-  $package_ensure         = 'present',
+  Stdlib::Ensure::Package $package_ensure = 'present',
   $workers                                = $facts['os_workers'],
   $event_alarm_topic                      = $facts['os_service_default'],
   $batch_size                             = $facts['os_service_default'],

manifests/notifier.pp

@@ -30,7 +30,7 @@
 class aodh::notifier (
   Boolean $manage_service                 = true,
   Boolean $enabled                        = true,
-  $package_ensure         = 'present',
+  Stdlib::Ensure::Package $package_ensure = 'present',
   $workers                                = $facts['os_workers'],
   $batch_size                             = $facts['os_service_default'],
   $batch_timeout                          = $facts['os_service_default'],

metadata.json

@@ -7,7 +7,7 @@
         },
         {
             "name": "puppetlabs/stdlib",
-            "version_requirement": ">= 5.0.0 <10.0.0"
+            "version_requirement": ">= 9.0.0 <10.0.0"
         },
         {
             "name": "openstack/keystone",