openstack/puppet-ceilometer
Code Issues Proposed changes

Remove deprecated notificaton_workers

Browse Source 
... because the parameter was deprecated during Wallaby cycle[1] in
favor of the new workers parameter.

[1] 15921006c5

Change-Id: I787bbe850cfcca737b9ad9de5db676b868549f2e
This commit is contained in:
Takashi Kajinami
2022-08-17 08:54:12 +09:00
parent 2f053934da
commit f42458bfe6
2 changed files with 6 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
manifests/agent/notification.pp
View File

@@ -83,12 +83,6 @@
# Defaults to ['gnocchi://'], If you are using collector # Defaults to ['gnocchi://'], If you are using collector
# override this to notifier:// instead. # override this to notifier:// instead.
# #
# DEPRECATED PARAMETERS
#
# [*notification_workers*]
# (Optional) Number of workers for notification service (integer value).
# Defaults to $::os_service_default.
#
class ceilometer::agent::notification ( class ceilometer::agent::notification (
$manage_service = true, $manage_service = true,
$enabled = true, $enabled = true,
@@ -103,20 +97,11 @@ class ceilometer::agent::notification (
$manage_pipeline = false, $manage_pipeline = false,
$pipeline_publishers = ['gnocchi://'], $pipeline_publishers = ['gnocchi://'],
$pipeline_config = undef, $pipeline_config = undef,
# DEPRECATED PARAMETERS
$notification_workers = undef,
) { ) {
include ceilometer::deps include ceilometer::deps
include ceilometer::params include ceilometer::params
if $notification_workers != undef {
warning('The notification_workers parameter is deprecated. Use the workers parameter instead')
$workers_real = $notification_workers
} else {
$workers_real = $workers
}
package { 'ceilometer-notification': package { 'ceilometer-notification':
ensure => $package_ensure, ensure => $package_ensure,
name => $::ceilometer::params::agent_notification_package_name, name => $::ceilometer::params::agent_notification_package_name,
@@ -185,7 +170,7 @@ class ceilometer::agent::notification (
ceilometer_config { ceilometer_config {
'notification/ack_on_event_error' : value => $ack_on_event_error; 'notification/ack_on_event_error' : value => $ack_on_event_error;
'notification/disable_non_metric_meters': value => $disable_non_metric_meters; 'notification/disable_non_metric_meters': value => $disable_non_metric_meters;
'notification/workers' : value => $workers_real; 'notification/workers' : value => $workers;
'notification/messaging_urls' : value => $messaging_urls, secret => true; 'notification/messaging_urls' : value => $messaging_urls, secret => true;
} }
} }

5
releasenotes/notes/remove-notification_workers-1d9ec9ec4b378498.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
upgrade:
- |
The ``ceilometer::agent::notification::notification_workers`` parameter has
been removed.