diff --git a/manifests/wsgi/apache.pp b/manifests/wsgi/apache.pp index 4cbb4f8..a030644 100644 --- a/manifests/wsgi/apache.pp +++ b/manifests/wsgi/apache.pp @@ -38,7 +38,7 @@ # # [*ssl*] # Use ssl ? (boolean) -# Optional. Defaults to true +# Optional. Defaults to false # # [*workers*] # Number of WSGI workers to spawn. @@ -101,7 +101,7 @@ class cloudkitty::wsgi::apache ( $port = 8889, $bind_host = undef, $path = '/', - $ssl = undef, + $ssl = false, $workers = $::os_workers, $ssl_cert = undef, $ssl_key = undef, @@ -119,11 +119,6 @@ class cloudkitty::wsgi::apache ( $custom_wsgi_process_options = {}, ) { - if $ssl == undef { - warning('Default of the ssl parameter will be changed in a future release') - } - $ssl_real = pick($ssl, true) - include cloudkitty::deps include cloudkitty::params @@ -136,7 +131,7 @@ class cloudkitty::wsgi::apache ( path => $path, priority => $priority, servername => $servername, - ssl => $ssl_real, + ssl => $ssl, ssl_ca => $ssl_ca, ssl_cert => $ssl_cert, ssl_certs_dir => $ssl_certs_dir, diff --git a/releasenotes/notes/disable-apache-ssl-6d2087199869e32d.yaml b/releasenotes/notes/disable-apache-ssl-6d2087199869e32d.yaml new file mode 100644 index 0000000..7d6fe26 --- /dev/null +++ b/releasenotes/notes/disable-apache-ssl-6d2087199869e32d.yaml @@ -0,0 +1,5 @@ +--- +upgrade: + - | + Default value of the ``cloudkitty::wsgi::apache::ssl`` parameter has been + changed from ``true`` to ``false`` and now ssl is disabled by default. diff --git a/spec/classes/cloudkitty_wsgi_apache_spec.rb b/spec/classes/cloudkitty_wsgi_apache_spec.rb index b56018e..a594007 100644 --- a/spec/classes/cloudkitty_wsgi_apache_spec.rb +++ b/spec/classes/cloudkitty_wsgi_apache_spec.rb @@ -10,7 +10,7 @@ describe 'cloudkitty::wsgi::apache' do :group => 'cloudkitty', :path => '/', :servername => facts[:fqdn], - :ssl => true, + :ssl => false, :threads => 1, :user => 'cloudkitty', :workers => facts[:os_workers], @@ -31,7 +31,7 @@ describe 'cloudkitty::wsgi::apache' do :servername => 'dummy.host', :bind_host => '10.42.51.1', :port => 12345, - :ssl => false, + :ssl => true, :wsgi_process_display_name => 'cloudkitty', :workers => 37, :custom_wsgi_process_options => { @@ -49,7 +49,7 @@ describe 'cloudkitty::wsgi::apache' do :group => 'cloudkitty', :path => '/', :servername => 'dummy.host', - :ssl => false, + :ssl => true, :threads => 1, :user => 'cloudkitty', :workers => 37,