openstack/puppet-cloudkitty
Code Issues Proposed changes

Do not test detail of keystone::resource::service_identity

Browse Source 
... but test interfaces of that resource type. This helps us avoid
direct breakage caused by any change in puppet-keystone.

Change-Id: I4cd18217e1b9d43659b0ab50941edd5c8e1f1497
This commit is contained in:
Takashi Kajinami
2021-09-29 00:20:51 +09:00
parent cd0cb0d286
commit cf655cc527
1 changed files with 53 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

142
spec/classes/cloudkitty_keystone_auth_spec.rb
View File

@@ -5,129 +5,77 @@
require 'spec_helper' require 'spec_helper'
describe 'cloudkitty::keystone::auth' do describe 'cloudkitty::keystone::auth' do
shared_examples_for 'cloudkitty-keystone-auth' do shared_examples_for 'cloudkitty::keystone::auth' do
context 'with default class parameters' do context 'with default class parameters' do
let :params do let :params do
{ :password => 'cloudkitty_password', { :password => 'cloudkitty_password' }
:tenant => 'foobar' }
end end
it { is_expected.to contain_keystone_user('cloudkitty').with( it { is_expected.to contain_keystone__resource__service_identity('cloudkitty').with(
:ensure => 'present', :configure_user => true,
:configure_user_role => true,
:configure_endpoint => true,
:service_name => 'cloudkitty',
:service_type => 'rating',
:service_description => 'OpenStack Rating Service',
:region => 'RegionOne',
:auth_name => 'cloudkitty',
:password => 'cloudkitty_password', :password => 'cloudkitty_password',
) } :email => 'cloudkitty@localhost',
:tenant => 'services',
it { is_expected.to contain_keystone_user_role('cloudkitty@foobar').with(
:ensure => 'present',
:roles => ['admin']
)}
it { is_expected.to contain_keystone_service('cloudkitty::rating').with(
:ensure => 'present',
:description => 'OpenStack Rating Service'
) }
it { is_expected.to contain_keystone_endpoint('RegionOne/cloudkitty::rating').with(
:ensure => 'present',
:public_url => 'http://127.0.0.1:8889', :public_url => 'http://127.0.0.1:8889',
:admin_url => 'http://127.0.0.1:8889',
:internal_url => 'http://127.0.0.1:8889', :internal_url => 'http://127.0.0.1:8889',
:admin_url => 'http://127.0.0.1:8889',
) } ) }
it { is_expected.to contain_keystone_role('rating').with( it { is_expected.to contain_keystone_role('rating').with_ensure('present') }
:ensure => 'present',
) }
end end
context 'when overriding URL parameters' do context 'when overriding parameters' do
let :params do let :params do
{ :password => 'cloudkitty_password', { :password => 'cloudkitty_password',
:auth_name => 'alt_cloudkitty',
:email => 'alt_cloudkitty@alt_localhost',
:tenant => 'alt_service',
:configure_endpoint => false,
:configure_user => false,
:configure_user_role => false,
:service_description => 'Alternative OpenStack Rating Service',
:service_name => 'alt_service',
:service_type => 'alt_rating',
:region => 'RegionTwo',
:public_url => 'https://10.10.10.10:80', :public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81', :internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81', } :admin_url => 'http://10.10.10.12:81',
:rating_role => 'alt_rating' }
end end
it { is_expected.to contain_keystone_endpoint('RegionOne/cloudkitty::rating').with( it { is_expected.to contain_keystone__resource__service_identity('cloudkitty').with(
:ensure => 'present', :configure_user => false,
:configure_user_role => false,
:configure_endpoint => false,
:service_name => 'alt_service',
:service_type => 'alt_rating',
:service_description => 'Alternative OpenStack Rating Service',
:region => 'RegionTwo',
:auth_name => 'alt_cloudkitty',
:password => 'cloudkitty_password',
:email => 'alt_cloudkitty@alt_localhost',
:tenant => 'alt_service',
:public_url => 'https://10.10.10.10:80', :public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81', :internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81', :admin_url => 'http://10.10.10.12:81',
) } ) }
end it { is_expected.to contain_keystone_role('alt_rating').with_ensure('present') }
context 'when overriding auth name' do
let :params do
{ :password => 'foo',
:auth_name => 'cloudkittyy' }
end
it { is_expected.to contain_keystone_user('cloudkittyy') }
it { is_expected.to contain_keystone_user_role('cloudkittyy@services') }
it { is_expected.to contain_keystone_service('cloudkitty::rating') }
it { is_expected.to contain_keystone_endpoint('RegionOne/cloudkitty::rating') }
end
context 'when overriding service name' do
let :params do
{ :service_name => 'cloudkitty_service',
:auth_name => 'cloudkitty',
:password => 'cloudkitty_password' }
end
it { is_expected.to contain_keystone_user('cloudkitty') }
it { is_expected.to contain_keystone_user_role('cloudkitty@services') }
it { is_expected.to contain_keystone_service('cloudkitty_service::rating') }
it { is_expected.to contain_keystone_endpoint('RegionOne/cloudkitty_service::rating') }
end
context 'when disabling user configuration' do
let :params do
{
:password => 'cloudkitty_password',
:configure_user => false
}
end
it { is_expected.not_to contain_keystone_user('cloudkitty') }
it { is_expected.to contain_keystone_user_role('cloudkitty@services') }
it { is_expected.to contain_keystone_service('cloudkitty::rating').with(
:ensure => 'present',
:description => 'OpenStack Rating Service'
) }
end
context 'when disabling user and user role configuration' do
let :params do
{
:password => 'cloudkitty_password',
:configure_user => false,
:configure_user_role => false
}
end
it { is_expected.not_to contain_keystone_user('cloudkitty') }
it { is_expected.not_to contain_keystone_user_role('cloudkitty@services') }
it { is_expected.to contain_keystone_service('cloudkitty::rating').with(
:ensure => 'present',
:description => 'OpenStack Rating Service'
) }
end end
context 'when disabling rating role management' do context 'when disabling rating role management' do
let :params do let :params do
{ { :password => 'cloudkitty_password',
:password => 'cloudkitty_password', :manage_rating_role => false }
:manage_rating_role => false,
:rating_role => 'rating',
}
end end
it { is_expected.not_to contain_keystone_role('rating') } it { is_expected.to_not contain_keystone_role('rating') }
end end
end end
@@ -139,7 +87,7 @@ describe 'cloudkitty::keystone::auth' do
facts.merge!(OSDefaults.get_facts()) facts.merge!(OSDefaults.get_facts())
end end
it_behaves_like 'cloudkitty-keystone-auth' it_behaves_like 'cloudkitty::keystone::auth'
end end
end end
end end