openstack/puppet-cloudkitty
Code Issues Proposed changes

Validate ensure parameter for package resources

Browse Source 
The minimum version of puppetlabs-stdlib has been bumped globally, so
now we can use the common type definition.

Change-Id: I59635d01085d31ce107493a03568545d83865c57
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
This commit is contained in:
Takashi Kajinami
2025-09-23 17:12:19 +09:00
parent 2af55ff806
commit e65812c1f7
4 changed files with 67 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
manifests/api.pp
View File

@@ -50,16 +50,16 @@
# Defaults to $facts['os_service_default']. # Defaults to $facts['os_service_default'].
# #
class cloudkitty::api ( class cloudkitty::api (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$host_ip = $facts['os_service_default'], $host_ip = $facts['os_service_default'],
$port = $facts['os_service_default'], $port = $facts['os_service_default'],
$pecan_debug = $facts['os_service_default'], $pecan_debug = $facts['os_service_default'],
Boolean $sync_db = true, Boolean $sync_db = true,
$service_name = 'httpd', $service_name = 'httpd',
$enable_proxy_headers_parsing = $facts['os_service_default'], $enable_proxy_headers_parsing = $facts['os_service_default'],
$max_request_body_size = $facts['os_service_default'], $max_request_body_size = $facts['os_service_default'],
) { ) {
include cloudkitty include cloudkitty
include cloudkitty::deps include cloudkitty::deps

2
manifests/client.pp
View File

@@ -9,7 +9,7 @@
# Defaults to 'present'. # Defaults to 'present'.
# #
class cloudkitty::client ( class cloudkitty::client (
$ensure = 'present' Stdlib::Ensure::Package $ensure = 'present'
) { ) {
include cloudkitty::deps include cloudkitty::deps
include cloudkitty::params include cloudkitty::params

88
manifests/init.pp
View File

@@ -211,50 +211,50 @@
# Defaults to undef # Defaults to undef
# #
class cloudkitty ( class cloudkitty (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
$rabbit_use_ssl = $facts['os_service_default'], $rabbit_use_ssl = $facts['os_service_default'],
$rabbit_heartbeat_timeout_threshold = $facts['os_service_default'], $rabbit_heartbeat_timeout_threshold = $facts['os_service_default'],
$rabbit_heartbeat_rate = $facts['os_service_default'], $rabbit_heartbeat_rate = $facts['os_service_default'],
$rabbit_ha_queues = $facts['os_service_default'], $rabbit_ha_queues = $facts['os_service_default'],
$rabbit_qos_prefetch_count = $facts['os_service_default'], $rabbit_qos_prefetch_count = $facts['os_service_default'],
$rabbit_quorum_queue = $facts['os_service_default'], $rabbit_quorum_queue = $facts['os_service_default'],
$rabbit_transient_queues_ttl = $facts['os_service_default'], $rabbit_transient_queues_ttl = $facts['os_service_default'],
$rabbit_transient_quorum_queue = $facts['os_service_default'], $rabbit_transient_quorum_queue = $facts['os_service_default'],
$rabbit_quorum_delivery_limit = $facts['os_service_default'], $rabbit_quorum_delivery_limit = $facts['os_service_default'],
$rabbit_quorum_max_memory_length = $facts['os_service_default'], $rabbit_quorum_max_memory_length = $facts['os_service_default'],
$rabbit_quorum_max_memory_bytes = $facts['os_service_default'], $rabbit_quorum_max_memory_bytes = $facts['os_service_default'],
$rabbit_use_queue_manager = $facts['os_service_default'], $rabbit_use_queue_manager = $facts['os_service_default'],
$rabbit_stream_fanout = $facts['os_service_default'], $rabbit_stream_fanout = $facts['os_service_default'],
$rabbit_enable_cancel_on_failover = $facts['os_service_default'], $rabbit_enable_cancel_on_failover = $facts['os_service_default'],
$kombu_ssl_ca_certs = $facts['os_service_default'], $kombu_ssl_ca_certs = $facts['os_service_default'],
$kombu_ssl_certfile = $facts['os_service_default'], $kombu_ssl_certfile = $facts['os_service_default'],
$kombu_ssl_keyfile = $facts['os_service_default'], $kombu_ssl_keyfile = $facts['os_service_default'],
$kombu_ssl_version = $facts['os_service_default'], $kombu_ssl_version = $facts['os_service_default'],
$kombu_reconnect_delay = $facts['os_service_default'], $kombu_reconnect_delay = $facts['os_service_default'],
$kombu_failover_strategy = $facts['os_service_default'], $kombu_failover_strategy = $facts['os_service_default'],
$kombu_compression = $facts['os_service_default'], $kombu_compression = $facts['os_service_default'],
$amqp_durable_queues = $facts['os_service_default'], $amqp_durable_queues = $facts['os_service_default'],
$amqp_auto_delete = $facts['os_service_default'], $amqp_auto_delete = $facts['os_service_default'],
$default_transport_url = $facts['os_service_default'], $default_transport_url = $facts['os_service_default'],
$rpc_response_timeout = $facts['os_service_default'], $rpc_response_timeout = $facts['os_service_default'],
$control_exchange = $facts['os_service_default'], $control_exchange = $facts['os_service_default'],
$notification_transport_url = $facts['os_service_default'], $notification_transport_url = $facts['os_service_default'],
$notification_driver = $facts['os_service_default'], $notification_driver = $facts['os_service_default'],
$notification_topics = $facts['os_service_default'], $notification_topics = $facts['os_service_default'],
$notification_retry = $facts['os_service_default'], $notification_retry = $facts['os_service_default'],
Boolean $purge_config = false, Boolean $purge_config = false,
$auth_strategy = 'keystone', $auth_strategy = 'keystone',
$api_paste_config = $facts['os_service_default'], $api_paste_config = $facts['os_service_default'],
$host = $facts['os_service_default'], $host = $facts['os_service_default'],
$state_backend = $facts['os_service_default'], $state_backend = $facts['os_service_default'],
$state_basepath = $facts['os_service_default'], $state_basepath = $facts['os_service_default'],
$output_backend = $facts['os_service_default'], $output_backend = $facts['os_service_default'],
$output_basepath = $facts['os_service_default'], $output_basepath = $facts['os_service_default'],
$pipeline = $facts['os_service_default'], $pipeline = $facts['os_service_default'],
$storage_backend = $facts['os_service_default'], $storage_backend = $facts['os_service_default'],
$storage_version = $facts['os_service_default'], $storage_version = $facts['os_service_default'],
$fetcher_backend = $facts['os_service_default'], $fetcher_backend = $facts['os_service_default'],
Optional[Hash] $metrics_config = undef, Optional[Hash] $metrics_config = undef,
) { ) {
include cloudkitty::params include cloudkitty::params
include cloudkitty::db include cloudkitty::db

24
manifests/processor.pp
View File

@@ -53,18 +53,18 @@
# Default to $facts['os_service_default'] # Default to $facts['os_service_default']
# #
class cloudkitty::processor ( class cloudkitty::processor (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$collector = 'gnocchi', $collector = 'gnocchi',
$window = $facts['os_service_default'], $window = $facts['os_service_default'],
$period = $facts['os_service_default'], $period = $facts['os_service_default'],
$wait_periods = $facts['os_service_default'], $wait_periods = $facts['os_service_default'],
$services = $facts['os_service_default'], $services = $facts['os_service_default'],
$auth_type = 'password', $auth_type = 'password',
$auth_section = 'keystone_authtoken', $auth_section = 'keystone_authtoken',
$region_name = $facts['os_service_default'], $region_name = $facts['os_service_default'],
$interface = $facts['os_service_default'], $interface = $facts['os_service_default'],
) { ) {
include cloudkitty::deps include cloudkitty::deps
include cloudkitty::params include cloudkitty::params