openstack/puppet-gnocchi
Code Issues Proposed changes

Debian api_uwsgi_config: Switch to :ini_setting

Browse Source 
On each puppet run, I'm seeing:
value changed ['12'] to '12' (corrective)

Therefore, this patch switches from :openstackconfig to :ini_setting
to make the 2nd run not changing anything.

Change-Id: Ib674673edec143841aa88d754ea2e9b0cb13be1a
This commit is contained in:
Thomas Goirand 2021-04-22 15:19:42 +02:00
parent 4245a9e823
commit e986276b77
3 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/puppet/provider/gnocchi_api_uwsgi_config/openstackconfig.rb → lib/puppet/provider/gnocchi_api_uwsgi_config/ini_setting.rb
View File

@ -1,6 +1,6 @@
Puppet::Type.type(:gnocchi_api_uwsgi_config).provide( Puppet::Type.type(:gnocchi_api_uwsgi_config).provide(
:openstackconfig, :ini_setting,
:parent => Puppet::Type.type(:openstack_config).provider(:ruby) :parent => Puppet::Type.type(:openstack_config).provider(:ini_setting)
) do ) do
def self.file_path def self.file_path

2
spec/spec_helper.rb
View File

@ -1,3 +1,5 @@
# Load libraries from openstacklib here to simulate how they live together in a real puppet run (for provider unit tests)
$LOAD_PATH.push(File.join(File.dirname(__FILE__), 'fixtures', 'modules', 'openstacklib', 'lib'))
require 'puppetlabs_spec_helper/module_spec_helper' require 'puppetlabs_spec_helper/module_spec_helper'
require 'shared_examples' require 'shared_examples'
require 'puppet-openstack_spec_helper/facts' require 'puppet-openstack_spec_helper/facts'

13
spec/unit/provider/gnocchi_api_uwsgi_config/openstackconfig_spec.rb → spec/unit/provider/gnocchi_api_uwsgi_config/ini_setting_spec.rb
View File

@ -9,19 +9,8 @@ $LOAD_PATH.push(
'inifile', 'inifile',
'lib') 'lib')
) )
$LOAD_PATH.push(
File.join(
File.dirname(__FILE__),
'..',
'..',
'..',
'fixtures',
'modules',
'openstacklib',
'lib')
)
require 'spec_helper' require 'spec_helper'
provider_class = Puppet::Type.type(:gnocchi_api_uwsgi_config).provider(:openstackconfig) provider_class = Puppet::Type.type(:gnocchi_api_uwsgi_config).provider(:ini_setting)
describe provider_class do describe provider_class do
it 'should default to the default setting when no other one is specified' do it 'should default to the default setting when no other one is specified' do