openstack/puppet-heat
Code Issues Proposed changes

Change memcache_socket_timeout to a float

Browse Source 
see https://review.opendev.org/#/c/519353/

Change-Id: I00f5e43146a0b937d2dfafa080f37c3601eed809
Closes-Bug: #1835162
This commit is contained in:
ZhongShengping 2019-07-03 15:19:27 +08:00
parent 82e5a7bc8b
commit 169e0ad3ce
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/cache.pp
View File

@ -62,7 +62,7 @@
# [*memcache_socket_timeout*]
# (Optional) Timeout in seconds for every call to a server.
# (dogpile.cache.memcache and oslo_cache.memcache_pool backends only).
# (integer value)
# (floating point value)
# Defaults to $::os_service_default
#
# [*memcache_pool_maxsize*]

4
releasenotes/notes/memcache_socket_timeout-9daa89a1532caf11.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
`memcache_socket_timeout` is changed to float value.

4
spec/classes/heat_cache_spec.rb
View File

@ -38,7 +38,7 @@ describe 'heat::cache' do
:debug_cache_backend => false,
:memcache_servers => ['memcached01:11211', 'memcached02:11211'],
:memcache_dead_retry => '60',
:memcache_socket_timeout => '300',
:memcache_socket_timeout => '300.0',
:memcache_pool_maxsize => '10',
:memcache_pool_unused_timeout => '120',
:memcache_pool_connection_get_timeout => '360',
@ -56,7 +56,7 @@ describe 'heat::cache' do
is_expected.to contain_heat_config('cache/debug_cache_backend').with_value('false')
is_expected.to contain_heat_config('cache/memcache_servers').with_value('memcached01:11211,memcached02:11211')
is_expected.to contain_heat_config('cache/memcache_dead_retry').with_value('60')
is_expected.to contain_heat_config('cache/memcache_socket_timeout').with_value('300')
is_expected.to contain_heat_config('cache/memcache_socket_timeout').with_value('300.0')
is_expected.to contain_heat_config('cache/memcache_pool_maxsize').with_value('10')
is_expected.to contain_heat_config('cache/memcache_pool_unused_timeout').with_value('120')
is_expected.to contain_heat_config('cache/memcache_pool_connection_get_timeout').with_value('360')