From 27bf3a0591d50f70642954b3b19613131bbedeee Mon Sep 17 00:00:00 2001 From: Daniel Abad Date: Thu, 30 Aug 2018 13:58:05 +0200 Subject: [PATCH] Expose the notification_level paramenter After merging https://review.openstack.org/#/c/581786/ oslo notifications are unusable in ironic unless the notification_level parameter is set. Thus, there is a need to expose this parameter via puppet Change-Id: I737501a010e310354c36d7b879132c9fefbff86e --- manifests/init.pp | 6 ++++++ .../notes/add-notification-level-7d21ada84df44ca5.yaml | 4 ++++ spec/classes/ironic_init_spec.rb | 1 + 3 files changed, 11 insertions(+) create mode 100644 releasenotes/notes/add-notification-level-7d21ada84df44ca5.yaml diff --git a/manifests/init.pp b/manifests/init.pp index eac9d918..7321c158 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -266,6 +266,10 @@ # (optional) AMQP topic used for OpenStack notifications # Defaults to $::os_service_default # +# [*notification_level*] +# (optional) Notification level for outgoing notifications +# Defaults to $::os_service_default +# class ironic ( $enabled = true, $package_ensure = 'present', @@ -322,6 +326,7 @@ class ironic ( $notification_transport_url = $::os_service_default, $notification_driver = $::os_service_default, $notification_topics = $::os_service_default, + $notification_level = $::os_service_default, ) { include ::ironic::deps @@ -351,6 +356,7 @@ class ironic ( 'DEFAULT/auth_strategy': value => $auth_strategy; 'DEFAULT/my_ip': value => $my_ip; 'DEFAULT/default_resource_class': value => $default_resource_class; + 'DEFAULT/notification_level': value => $notification_level; } if $sync_db { diff --git a/releasenotes/notes/add-notification-level-7d21ada84df44ca5.yaml b/releasenotes/notes/add-notification-level-7d21ada84df44ca5.yaml new file mode 100644 index 00000000..ddbc226c --- /dev/null +++ b/releasenotes/notes/add-notification-level-7d21ada84df44ca5.yaml @@ -0,0 +1,4 @@ +--- +features: + - | + Expose the ``notification_level`` parameter in ``::ironic`` diff --git a/spec/classes/ironic_init_spec.rb b/spec/classes/ironic_init_spec.rb index 7d4cf23c..4e5dd4cb 100644 --- a/spec/classes/ironic_init_spec.rb +++ b/spec/classes/ironic_init_spec.rb @@ -113,6 +113,7 @@ describe 'ironic' do is_expected.to contain_ironic_config('DEFAULT/control_exchange').with_value('') is_expected.to contain_ironic_config('DEFAULT/transport_url').with_value('').with_secret(true) is_expected.to contain_ironic_config('DEFAULT/default_resource_class').with_value('') + is_expected.to contain_ironic_config('DEFAULT/notification_level').with_value('') end end