diff --git a/manifests/drivers/redfish.pp b/manifests/drivers/redfish.pp index 7fb1103d..41cb8f4e 100644 --- a/manifests/drivers/redfish.pp +++ b/manifests/drivers/redfish.pp @@ -67,6 +67,10 @@ # update tasks. # Defaults to $facts['os_service_default'] # +# [*firmware_source*] +# (optional) Specifies how firmware image should be served. +# Defaults to $facts['os_service_default'] +# class ironic::drivers::redfish ( $package_ensure = 'present', $connection_attempts = $facts['os_service_default'], @@ -80,6 +84,7 @@ class ironic::drivers::redfish ( $file_permission = $facts['os_service_default'], $firmware_update_status_interval = $facts['os_service_default'], $firmware_update_fail_interval = $facts['os_service_default'], + $firmware_source = $facts['os_service_default'], ) { include ironic::deps @@ -97,6 +102,7 @@ class ironic::drivers::redfish ( 'redfish/file_permission': value => $file_permission; 'redfish/firmware_update_status_interval': value => $firmware_update_status_interval; 'redfish/firmware_update_fail_interval': value => $firmware_update_fail_interval; + 'redfish/firmware_source': value => $firmware_source; } ensure_packages('python-sushy', diff --git a/releasenotes/notes/redfish-firmware_source-ab135c6ff58b2a1f.yaml b/releasenotes/notes/redfish-firmware_source-ab135c6ff58b2a1f.yaml new file mode 100644 index 00000000..e32b20f8 --- /dev/null +++ b/releasenotes/notes/redfish-firmware_source-ab135c6ff58b2a1f.yaml @@ -0,0 +1,4 @@ +--- +features: + - | + The new ``ironic::redfish::firmware_source`` parameter has been added. diff --git a/spec/classes/ironic_drivers_redfish_spec.rb b/spec/classes/ironic_drivers_redfish_spec.rb index 54acd178..4dea5a5e 100644 --- a/spec/classes/ironic_drivers_redfish_spec.rb +++ b/spec/classes/ironic_drivers_redfish_spec.rb @@ -38,6 +38,7 @@ describe 'ironic::drivers::redfish' do is_expected.to contain_ironic_config('redfish/file_permission').with_value('') is_expected.to contain_ironic_config('redfish/firmware_update_status_interval').with_value('') is_expected.to contain_ironic_config('redfish/firmware_update_fail_interval').with_value('') + is_expected.to contain_ironic_config('redfish/firmware_source').with_value('') end it 'installs sushy package' do @@ -62,7 +63,8 @@ describe 'ironic::drivers::redfish' do :file_permission => '0o644', :firmware_update_status_interval => 60, :firmware_update_fail_interval => 60, - ) + :firmware_source => 'http', + ) end it 'should replace default parameter with new value' do @@ -77,6 +79,7 @@ describe 'ironic::drivers::redfish' do is_expected.to contain_ironic_config('redfish/file_permission').with_value('0o644') is_expected.to contain_ironic_config('redfish/firmware_update_status_interval').with_value(60) is_expected.to contain_ironic_config('redfish/firmware_update_fail_interval').with_value(60) + is_expected.to contain_ironic_config('redfish/firmware_source').with_value('http') end end