openstack/puppet-ironic
Code Issues Proposed changes

Validate ensure parameter for package resources

Browse Source 
The minimum version of puppetlabs-stdlib has been bumped globally, so
now we can use the common type definition.

Change-Id: Id05e7d78967eac898ddf8fe5f66d58722cbe7ace
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
This commit is contained in:
Takashi Kajinami
2025-09-23 18:15:47 +09:00
parent a8c25be7f8
commit 3eac2ca560
13 changed files with 164 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/api.pp
View File

@@ -74,7 +74,7 @@
# Defaults to $facts['os_service_default']. # Defaults to $facts['os_service_default'].
# #
class ironic::api ( class ironic::api (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$service_name = $ironic::params::api_service, $service_name = $ironic::params::api_service,

2
manifests/client.pp
View File

@@ -27,7 +27,7 @@
# #
# #
class ironic::client ( class ironic::client (
$package_ensure = present Stdlib::Ensure::Package $package_ensure = present,
) { ) {
include ironic::deps include ironic::deps
include ironic::params include ironic::params

2
manifests/conductor.pp
View File

@@ -264,7 +264,7 @@
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# #
class ironic::conductor ( class ironic::conductor (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $enabled = true, Boolean $enabled = true,
Boolean $manage_service = true, Boolean $manage_service = true,
$enabled_hardware_types = $facts['os_service_default'], $enabled_hardware_types = $facts['os_service_default'],

2
manifests/drivers/ansible.pp
View File

@@ -67,7 +67,7 @@
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# #
class ironic::drivers::ansible ( class ironic::drivers::ansible (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
$ansible_extra_args = $facts['os_service_default'], $ansible_extra_args = $facts['os_service_default'],
$playbooks_path = $facts['os_service_default'], $playbooks_path = $facts['os_service_default'],
$config_file_path = $facts['os_service_default'], $config_file_path = $facts['os_service_default'],

2
manifests/drivers/drac.pp
View File

@@ -47,7 +47,7 @@
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# #
class ironic::drivers::drac ( class ironic::drivers::drac (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
$query_raid_config_job_status_interval = $facts['os_service_default'], $query_raid_config_job_status_interval = $facts['os_service_default'],
$boot_device_job_status_timeout = $facts['os_service_default'], $boot_device_job_status_timeout = $facts['os_service_default'],
$config_job_max_retries = $facts['os_service_default'], $config_job_max_retries = $facts['os_service_default'],

2
manifests/drivers/ilo.pp
View File

@@ -43,7 +43,7 @@ class ironic::drivers::ilo (
$client_port = $facts['os_service_default'], $client_port = $facts['os_service_default'],
$use_web_server_for_images = $facts['os_service_default'], $use_web_server_for_images = $facts['os_service_default'],
$default_boot_mode = $facts['os_service_default'], $default_boot_mode = $facts['os_service_default'],
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
) { ) {
include ironic::deps include ironic::deps
include ironic::params include ironic::params

2
manifests/drivers/redfish.pp
View File

@@ -92,7 +92,7 @@
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# #
class ironic::drivers::redfish ( class ironic::drivers::redfish (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
$connection_attempts = $facts['os_service_default'], $connection_attempts = $facts['os_service_default'],
$connection_retry_interval = $facts['os_service_default'], $connection_retry_interval = $facts['os_service_default'],
$connection_cache_size = $facts['os_service_default'], $connection_cache_size = $facts['os_service_default'],

2
manifests/init.pp
View File

@@ -242,7 +242,7 @@
# #
class ironic ( class ironic (
Boolean $enabled = true, Boolean $enabled = true,
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
$host = $facts['os_service_default'], $host = $facts['os_service_default'],
$my_ip = $facts['os_service_default'], $my_ip = $facts['os_service_default'],
$my_ipv6 = $facts['os_service_default'], $my_ipv6 = $facts['os_service_default'],

2
manifests/inspector.pp
View File

@@ -330,7 +330,7 @@
# Defaults to true # Defaults to true
# #
class ironic::inspector ( class ironic::inspector (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$host = $facts['os_service_default'], $host = $facts['os_service_default'],

2
manifests/inspector/client.pp
View File

@@ -9,7 +9,7 @@
# Defaults to present # Defaults to present
# #
class ironic::inspector::client ( class ironic::inspector::client (
$package_ensure = present Stdlib::Ensure::Package $package_ensure = present,
) { ) {
include ironic::deps include ironic::deps
include ironic::params include ironic::params

2
manifests/pxe.pp
View File

@@ -104,7 +104,7 @@
# Defaults to {} # Defaults to {}
# #
class ironic::pxe ( class ironic::pxe (
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
Stdlib::Absolutepath $tftp_root = '/tftpboot', Stdlib::Absolutepath $tftp_root = '/tftpboot',

2
manifests/reports.pp
View File

@@ -29,7 +29,7 @@ class ironic::reports (
$log_dir = $facts['os_service_default'], $log_dir = $facts['os_service_default'],
$file_event_handler = $facts['os_service_default'], $file_event_handler = $facts['os_service_default'],
$file_event_handler_interval = $facts['os_service_default'], $file_event_handler_interval = $facts['os_service_default'],
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_package = true, Boolean $manage_package = true,
) { ) {
include ironic::deps include ironic::deps

2
manifests/vnc.pp
View File

@@ -73,7 +73,7 @@
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# #
class ironic::vnc ( class ironic::vnc (
$package_ensure = present, Stdlib::Ensure::Package $package_ensure = present,
Boolean $enabled = true, Boolean $enabled = true,
Boolean $manage_service = true, Boolean $manage_service = true,
$host_ip = $facts['os_service_default'], $host_ip = $facts['os_service_default'],