openstack/puppet-ironic
Code Issues Proposed changes

Do not show diffs of image files

Browse Source 
... because these are binary files and diffs are not really useful.

Change-Id: Ife95969ab90bdba3d3af55e021b7bd6b76f94b2c
This commit is contained in:
Takashi Kajinami
2022-06-24 01:35:29 +09:00
parent 05ada3d17f
commit 8672adf57a
2 changed files with 48 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/pxe.pp
View File

@@ -228,6 +228,7 @@ class ironic::pxe (
mode => '0744', mode => '0744',
source => "${::ironic::params::ipxe_rom_dir}/undionly.kpxe", source => "${::ironic::params::ipxe_rom_dir}/undionly.kpxe",
backup => false, backup => false,
show_diff => false,
require => Anchor['ironic-inspector::install::end'], require => Anchor['ironic-inspector::install::end'],
tag => 'ironic-tftp-file', tag => 'ironic-tftp-file',
} }
@@ -240,6 +241,7 @@ class ironic::pxe (
mode => '0744', mode => '0744',
source => "${::ironic::params::ipxe_rom_dir}/${ipxe_name_base}${arch}.efi", source => "${::ironic::params::ipxe_rom_dir}/${ipxe_name_base}${arch}.efi",
backup => false, backup => false,
show_diff => false,
require => Anchor['ironic-inspector::install::end'], require => Anchor['ironic-inspector::install::end'],
tag => 'ironic-tftp-file', tag => 'ironic-tftp-file',
} }

4
spec/classes/ironic_pxe_spec.rb
View File

@@ -60,6 +60,7 @@ describe 'ironic::pxe' do
'require' => 'Anchor[ironic-inspector::install::end]', 'require' => 'Anchor[ironic-inspector::install::end]',
'seltype' => 'tftpdir_t', 'seltype' => 'tftpdir_t',
'ensure' => 'file', 'ensure' => 'file',
'show_diff' => false,
'backup' => false, 'backup' => false,
) )
end end
@@ -70,6 +71,7 @@ describe 'ironic::pxe' do
'require' => 'Anchor[ironic-inspector::install::end]', 'require' => 'Anchor[ironic-inspector::install::end]',
'seltype' => 'tftpdir_t', 'seltype' => 'tftpdir_t',
'ensure' => 'file', 'ensure' => 'file',
'show_diff' => false,
'backup' => false, 'backup' => false,
) )
end end
@@ -111,6 +113,7 @@ describe 'ironic::pxe' do
'require' => 'Anchor[ironic-inspector::install::end]', 'require' => 'Anchor[ironic-inspector::install::end]',
'seltype' => 'tftpdir_t', 'seltype' => 'tftpdir_t',
'ensure' => 'file', 'ensure' => 'file',
'show_diff' => false,
'backup' => false, 'backup' => false,
) )
end end
@@ -121,6 +124,7 @@ describe 'ironic::pxe' do
'require' => 'Anchor[ironic-inspector::install::end]', 'require' => 'Anchor[ironic-inspector::install::end]',
'seltype' => 'tftpdir_t', 'seltype' => 'tftpdir_t',
'ensure' => 'file', 'ensure' => 'file',
'show_diff' => false,
'backup' => false, 'backup' => false,
) )
end end