diff --git a/manifests/deps.pp b/manifests/deps.pp index 7354724d..30abc6b0 100644 --- a/manifests/deps.pp +++ b/manifests/deps.pp @@ -43,9 +43,12 @@ class ironic::deps { -> anchor { 'ironic-inspector::dbsync::end': } ~> anchor { 'ironic-inspector::service::begin': } ~> Service<| tag == 'ironic-inspector-service' |> - ~> Service<| tag == 'ironic-inspector-dnsmasq-service' |> ~> anchor { 'ironic-inspector::service::end': } + Anchor['ironic-inspector::service::begin'] + ~> Service<| tag == 'ironic-inspector-dnsmasq-service' |> + ~> Anchor['ironic-inspector::service::end'] + Anchor['ironic::db::end'] -> Anchor['ironic-inspector::dbsync::begin'] diff --git a/manifests/inspector.pp b/manifests/inspector.pp index 53328f5f..8e9c5356 100644 --- a/manifests/inspector.pp +++ b/manifests/inspector.pp @@ -260,7 +260,7 @@ class ironic::inspector ( file { '/etc/ironic-inspector/dnsmasq.conf': ensure => 'present', content => template('ironic/inspector_dnsmasq_tftp.erb'), - require => Anchor['ironic-inspector::config::begin'], + tag => 'ironic-inspector-dnsmasq-file', } file { "${tftp_root_real}/pxelinux.cfg/default": ensure => 'present', @@ -268,7 +268,7 @@ class ironic::inspector ( owner => $::ironic::params::inspector_user, group => $::ironic::params::inspector_group, content => template('ironic/inspector_pxelinux_cfg.erb'), - require => Anchor['ironic-inspector::config::begin'], + tag => 'ironic-inspector-dnsmasq-file', } } @@ -276,7 +276,7 @@ class ironic::inspector ( file { '/etc/ironic-inspector/dnsmasq.conf': ensure => 'present', content => template('ironic/inspector_dnsmasq_http.erb'), - require => Anchor['ironic-inspector::config::begin'], + tag => 'ironic-inspector-dnsmasq-file', } file { "${http_root_real}/inspector.ipxe": ensure => 'present', @@ -284,7 +284,7 @@ class ironic::inspector ( owner => $::ironic::params::inspector_user, group => $::ironic::params::inspector_group, content => template('ironic/inspector_ipxe.erb'), - require => Anchor['ironic-inspector::config::begin'], + tag => 'ironic-inspector-dnsmasq-file', } } @@ -295,7 +295,7 @@ class ironic::inspector ( seltype => 'tftpdir_t', owner => $::ironic::params::inspector_user, group => $::ironic::params::inspector_group, - require => Anchor['ironic-inspector::config::begin'], + tag => 'ironic-inspector-dnsmasq-file', } file { "${tftp_root_real}/ppc64le/default": ensure => 'present', @@ -303,10 +303,14 @@ class ironic::inspector ( owner => $::ironic::params::inspector_user, group => $::ironic::params::inspector_group, content => template('ironic/inspector_pxelinux_cfg.erb'), - require => Anchor['ironic-inspector::config::begin'], + tag => 'ironic-inspector-dnsmasq-file', } } + Anchor['ironic-inspector::config::begin'] + -> File<| tag == 'ironic-inspector-dnsmasq-file' |> + -> Anchor['ironic-inspector::config::end'] + # Configure inspector.conf #Processing hooks string diff --git a/spec/classes/ironic_inspector_spec.rb b/spec/classes/ironic_inspector_spec.rb index 3c13591a..a237af36 100644 --- a/spec/classes/ironic_inspector_spec.rb +++ b/spec/classes/ironic_inspector_spec.rb @@ -132,8 +132,8 @@ describe 'ironic::inspector' do it 'should contain file /etc/ironic-inspector/dnsmasq.conf' do is_expected.to contain_file('/etc/ironic-inspector/dnsmasq.conf').with( 'ensure' => 'present', - 'require' => 'Anchor[ironic-inspector::config::begin]', 'content' => /pxelinux/, + 'tag' => 'ironic-inspector-dnsmasq-file', ) is_expected.to contain_file('/etc/ironic-inspector/dnsmasq.conf').with_content( /dhcp-range=192.168.0.100,192.168.0.120,10m/ @@ -178,8 +178,8 @@ describe 'ironic::inspector' do 'group' => 'ironic-inspector', 'seltype' => 'tftpdir_t', 'ensure' => 'present', - 'require' => 'Anchor[ironic-inspector::config::begin]', 'content' => /default/, + 'tag' => 'ironic-inspector-dnsmasq-file', ) is_expected.to contain_file('/tftpboot/pxelinux.cfg/default').with_content( /^append initrd=agent.ramdisk ipa-inspection-callback-url=http:\/\/192.168.0.1:5050\/v1\/continue / @@ -227,8 +227,8 @@ describe 'ironic::inspector' do it 'should contain file /etc/ironic-inspector/dnsmasq.conf' do is_expected.to contain_file('/etc/ironic-inspector/dnsmasq.conf').with( 'ensure' => 'present', - 'require' => 'Anchor[ironic-inspector::config::begin]', 'content' => /ipxe/, + 'tag' => 'ironic-inspector-dnsmasq-file', ) is_expected.to contain_file('/etc/ironic-inspector/dnsmasq.conf').with_content( /dhcp-boot=tag:ipxe,http:\/\/192.168.0.1:3816\/inspector.ipxe/ @@ -268,7 +268,6 @@ describe 'ironic::inspector' do 'group' => 'ironic-inspector', 'seltype' => 'httpd_sys_content_t', 'ensure' => 'present', - 'require' => 'Anchor[ironic-inspector::config::begin]', 'content' => /ipxe/, ) is_expected.to contain_file('/var/www/httpboot/inspector.ipxe').with_content( @@ -333,7 +332,6 @@ describe 'ironic::inspector' do is_expected.to contain_file('/tftpboot/ppc64le').with( 'owner' => 'ironic-inspector', 'group' => 'ironic-inspector', - 'require' => 'Anchor[ironic-inspector::config::begin]', 'ensure' => 'directory', 'seltype' => 'tftpdir_t', ) @@ -344,7 +342,6 @@ describe 'ironic::inspector' do 'group' => 'ironic-inspector', 'seltype' => 'tftpdir_t', 'ensure' => 'present', - 'require' => 'Anchor[ironic-inspector::config::begin]', 'content' => /default/, ) is_expected.to contain_file('/tftpboot/ppc64le/default').with_content( @@ -375,8 +372,8 @@ describe 'ironic::inspector' do 'group' => 'ironic-inspector', 'seltype' => 'tftpdir_t', 'ensure' => 'present', - 'require' => 'Anchor[ironic-inspector::config::begin]', 'content' => /default/, + 'tag' => 'ironic-inspector-dnsmasq-file', ) is_expected.to contain_file('/tftpboot/ppc64le/default').with_content( /^append initrd=agent.ramdisk ipa-inspection-callback-url=http:\/\/192.168.0.1:5050\/v1\/continue /