From e8d678c46529525ef275c8d7448523a8f8417da1 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Sun, 24 Jul 2022 00:35:38 +0900 Subject: [PATCH] Revert "CentOS 9: Disable unit tests dependent on puppet-postgresql" This reverts commit f4a4d65822f08dd8977a50cd3e50178ec0960c91. Reason for revert: puppet-postgresql 8.1.0 was released and now the module supports RHEL 9 (and CentOS 9 effectively). Note: This change adds the service_provider fact in test fact data because it is required by puppet-postgresql. Depends-on: https://review.opendev.org/850705 Change-Id: I30e0b9cd798fff3fff3b81d7355c3dda239e033d --- spec/classes/ironic_db_postgresql_spec.rb | 10 ++++------ spec/classes/ironic_inspector_db_postgresql_spec.rb | 11 ++++++----- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/spec/classes/ironic_db_postgresql_spec.rb b/spec/classes/ironic_db_postgresql_spec.rb index 6d54dc03..e8f761e0 100644 --- a/spec/classes/ironic_db_postgresql_spec.rb +++ b/spec/classes/ironic_db_postgresql_spec.rb @@ -32,15 +32,13 @@ describe 'ironic::db::postgresql' do context "on #{os}" do let (:facts) do facts.merge(OSDefaults.get_facts({ - :os_workers => 8, - :concat_basedir => '/var/lib/puppet/concat' + # puppet-postgresql requires the service_provider fact provided by + # puppetlabs-postgresql. + :service_provider => 'systemd' })) end - # TODO(tkajinam): Remove this once puppet-postgresql supports CentOS 9 - unless facts[:osfamily] == 'RedHat' and facts[:operatingsystemmajrelease].to_i >= 9 - it_behaves_like 'ironic::db::postgresql' - end + it_behaves_like 'ironic::db::postgresql' end end diff --git a/spec/classes/ironic_inspector_db_postgresql_spec.rb b/spec/classes/ironic_inspector_db_postgresql_spec.rb index a8d03cfe..9a07d626 100644 --- a/spec/classes/ironic_inspector_db_postgresql_spec.rb +++ b/spec/classes/ironic_inspector_db_postgresql_spec.rb @@ -31,13 +31,14 @@ describe 'ironic::inspector::db::postgresql' do }).each do |os,facts| context "on #{os}" do let (:facts) do - facts.merge(OSDefaults.get_facts()) + facts.merge(OSDefaults.get_facts({ + # puppet-postgresql requires the service_provider fact provided by + # puppetlabs-postgresql. + :service_provider => 'systemd' + })) end - # TODO(tkajinam): Remove this once puppet-postgresql supports CentOS 9 - unless facts[:osfamily] == 'RedHat' and facts[:operatingsystemmajrelease].to_i >= 9 - it_behaves_like 'ironic::inspector::db::postgresql' - end + it_behaves_like 'ironic::inspector::db::postgresql' end end