openstack/puppet-manila
Code Issues Proposed changes

Merge "Do not hard-code [oslo_messaging_amqp] container_name"

Browse Source
This commit is contained in:
Zuul
2023-07-22 22:24:28 +00:00
committed by Gerrit Code Review
parent 61ae2c64e6 ebb199a55c
commit 0997601839
3 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/init.pp
View File

@@ -234,7 +234,7 @@ class manila (
$amqp_server_request_prefix = $facts['os_service_default'], $amqp_server_request_prefix = $facts['os_service_default'],
$amqp_broadcast_prefix = $facts['os_service_default'], $amqp_broadcast_prefix = $facts['os_service_default'],
$amqp_group_request_prefix = $facts['os_service_default'], $amqp_group_request_prefix = $facts['os_service_default'],
$amqp_container_name = 'guest', $amqp_container_name = $facts['os_service_default'],
$amqp_idle_timeout = $facts['os_service_default'], $amqp_idle_timeout = $facts['os_service_default'],
$amqp_trace = $facts['os_service_default'], $amqp_trace = $facts['os_service_default'],
$amqp_ssl_ca_file = $facts['os_service_default'], $amqp_ssl_ca_file = $facts['os_service_default'],

6
releasenotes/notes/amqp_container_name-use_default-2ea9e17fcb213273.yaml Normal file
View File

@@ -0,0 +1,6 @@
---
fixes:
- |
The default value of ``manila::amqp_container_name`` has been updated and
now the service default value is used by default, so that a unique value
is generated by the `oslo.meesaging` library.

2
spec/classes/manila_init_spec.rb
View File

@@ -213,7 +213,7 @@ describe 'manila' do
:server_request_prefix => '<SERVICE DEFAULT>', :server_request_prefix => '<SERVICE DEFAULT>',
:broadcast_prefix => '<SERVICE DEFAULT>', :broadcast_prefix => '<SERVICE DEFAULT>',
:group_request_prefix => '<SERVICE DEFAULT>', :group_request_prefix => '<SERVICE DEFAULT>',
:container_name => 'guest', :container_name => '<SERVICE DEFAULT>',
:idle_timeout => '<SERVICE DEFAULT>', :idle_timeout => '<SERVICE DEFAULT>',
:trace => '<SERVICE DEFAULT>', :trace => '<SERVICE DEFAULT>',
:ssl_ca_file => '<SERVICE DEFAULT>', :ssl_ca_file => '<SERVICE DEFAULT>',