From 4fd2e39e83cc61e3dbf6a7492dc74c3b24830e88 Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <tkajinam@redhat.com>
Date: Mon, 27 Dec 2021 10:42:41 +0900
Subject: [PATCH] Load libraries in a single place

This change refactors how the dependent libraries are loaded during
unit tests, and load the libraries in the base spec_helper to avoid
duplicate and redundant implementations.

Change-Id: I984c4b8bff2aed7f39b15cb9b6d7d7378fdffa18
---
 spec/spec_helper.rb                           |  3 +++
 .../manila_api_paste_ini/ini_setting_spec.rb  | 22 ---------------
 .../ini_setting_spec.rb                       | 16 -----------
 .../manila_config/openstackconfig_spec.rb     | 27 -------------------
 4 files changed, 3 insertions(+), 65 deletions(-)

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 4a5c46c3..33f27e2d 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -1,3 +1,6 @@
+# Load libraries here to simulate how they live together in a real puppet run (for provider unit tests)
+$LOAD_PATH.push(File.join(File.dirname(__FILE__), 'fixtures', 'modules', 'inifile', 'lib'))
+$LOAD_PATH.push(File.join(File.dirname(__FILE__), 'fixtures', 'modules', 'openstacklib', 'lib'))
 require 'puppetlabs_spec_helper/module_spec_helper'
 require 'shared_examples'
 require 'puppet-openstack_spec_helper/facts'
diff --git a/spec/unit/provider/manila_api_paste_ini/ini_setting_spec.rb b/spec/unit/provider/manila_api_paste_ini/ini_setting_spec.rb
index 511213c7..c46967a0 100644
--- a/spec/unit/provider/manila_api_paste_ini/ini_setting_spec.rb
+++ b/spec/unit/provider/manila_api_paste_ini/ini_setting_spec.rb
@@ -1,25 +1,3 @@
-$LOAD_PATH.push(
-  File.join(
-    File.dirname(__FILE__),
-    '..',
-    '..',
-    '..',
-    'fixtures',
-    'modules',
-    'inifile',
-    'lib')
-)
-$LOAD_PATH.push(
-  File.join(
-    File.dirname(__FILE__),
-    '..',
-    '..',
-    '..',
-    'fixtures',
-    'modules',
-    'openstacklib',
-    'lib')
-)
 require 'spec_helper'
 provider_class = Puppet::Type.type(:manila_api_paste_ini).provider(:ini_setting)
 describe provider_class do
diff --git a/spec/unit/provider/manila_api_uwsgi_config/ini_setting_spec.rb b/spec/unit/provider/manila_api_uwsgi_config/ini_setting_spec.rb
index e551dd08..8a10cb64 100644
--- a/spec/unit/provider/manila_api_uwsgi_config/ini_setting_spec.rb
+++ b/spec/unit/provider/manila_api_uwsgi_config/ini_setting_spec.rb
@@ -1,19 +1,3 @@
-#
-# these tests are a little concerning b/c they are hacking around the
-# modulepath, so these tests will not catch issues that may eventually arise
-# related to loading these plugins.
-# I could not, for the life of me, figure out how to programatcally set the modulepath
-$LOAD_PATH.push(
-  File.join(
-    File.dirname(__FILE__),
-    '..',
-    '..',
-    '..',
-    'fixtures',
-    'modules',
-    'inifile',
-    'lib')
-)
 require 'spec_helper'
 provider_class = Puppet::Type.type(:manila_api_uwsgi_config).provider(:ini_setting)
 describe provider_class do
diff --git a/spec/unit/provider/manila_config/openstackconfig_spec.rb b/spec/unit/provider/manila_config/openstackconfig_spec.rb
index 381549ec..9401f87c 100644
--- a/spec/unit/provider/manila_config/openstackconfig_spec.rb
+++ b/spec/unit/provider/manila_config/openstackconfig_spec.rb
@@ -1,30 +1,3 @@
-#
-# these tests are a little concerning b/c they are hacking around the
-# modulepath, so these tests will not catch issues that may eventually arise
-# related to loading these plugins.
-# I could not, for the life of me, figure out how to programmatically set the modulepath
-$LOAD_PATH.push(
-  File.join(
-    File.dirname(__FILE__),
-    '..',
-    '..',
-    '..',
-    'fixtures',
-    'modules',
-    'inifile',
-    'lib')
-)
-$LOAD_PATH.push(
-  File.join(
-    File.dirname(__FILE__),
-    '..',
-    '..',
-    '..',
-    'fixtures',
-    'modules',
-    'openstacklib',
-    'lib')
-)
 require 'spec_helper'
 provider_class = Puppet::Type.type(:manila_config).provider(:openstackconfig)
 describe provider_class do