openstack/puppet-manila
Code Issues Proposed changes

Do not validate database_connection format

Browse Source 
Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: If2764453402c460e9a96b91400bd6974c48fcf02
This commit is contained in:
Takashi Kajinami 2020-08-31 17:51:23 +09:00
parent 1aef7d228c
commit 5317e909dc
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -78,9 +78,6 @@ class manila::db (
$database_retry_interval_real = pick($::manila::database_retry_interval, $database_retry_interval)
$database_max_overflow_real = pick($::manila::database_max_overflow, $database_max_overflow)
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection_real,
['^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'manila_config':
connection => $database_connection_real,
connection_recycle_time => $database_connection_recycle_time_real,